Skip to content

ci: rewrite git SSH to HTTPS so Dependabot e2e can install - #552

Merged
tomymaritano merged 1 commit into
developfrom
cursor/fix-dependabot-e2e-https-27d2
Aug 22, 2026
Merged

ci: rewrite git SSH to HTTPS so Dependabot e2e can install#552
tomymaritano merged 1 commit into
developfrom
cursor/fix-dependabot-e2e-https-27d2

Conversation

@tomymaritano

@tomymaritano tomymaritano commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

Dependabot PRs fail the required e2e check in ~20s during pnpm install, not during Playwright. Automerge is already enabled; it cannot land while e2e is red.

Exact failure (PR #482 job 96541625973, also #464 / #456 / #462 and commitlint on #464):

ERROR  Command failed with exit code 128: git clone git@github.com:electron/node-gyp.git ...
git@github.com: Permission denied (publickey).

This is not missing repo secrets. Dependabot-regenerated lockfiles resolve @electron/node-gyp as a git dep whose resolution.repo is SSH:

# PR #456 (shell-quote) lockfile
'@electron/node-gyp@git+https://git@github.com:electron/node-gyp.git#06b29aa...'
resolution: {commit: 06b29aa..., repo: git@github.com:electron/node-gyp.git, type: git}

# develop lockfile (e2e green after #541)
'@electron/node-gyp@https://codeload.github.com/electron/node-gyp/tar.gz/06b29aa...'
resolution: {tarball: https://codeload.github.com/electron/node-gyp/tar.gz/06b29aa...}

pnpm clones resolution.repo over SSH. GitHub-hosted runners have no deploy key.

The setup job already rewrites SSH to HTTPS and therefore succeeds on the same PRs. e2e and commitlint did a fresh pnpm install without that rewrite.

develop itself is green after #541 — its lockfile uses the HTTPS tarball, so e2e never hits the SSH clone.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Fix

Add the same git config --global 'url.https://github.com/.insteadOf' 'git@github.com:' step that setup / release / build / docs already use:

  • .github/workflows/ci.yml e2e job — unblocks the required e2e check
  • .github/workflows/pr-title.yml — same SSH death on Dependabot lockfiles

Existing Dependabot PRs (#482, #464, #462, #460, #459, #456, #451, #431, #430, #248) should go green after rebase onto this develop change (the merge commit picks up the workflow).

Related Issues

Closes #544

Checklist

  • I've read CONTRIBUTING.md
  • Tests pass locally (pnpm test) — workflow-only change; no product code
  • Build succeeds (pnpm build) — not applicable
  • PR targets develop branch (not main)
Open in Web Open in Cursor 

Dependabot lockfiles resolve @electron/node-gyp as git@github.com:.
The setup job already rewrites that to HTTPS; e2e and commitlint did
not, so those checks died in ~20s with Permission denied (publickey).

Closes #544

Co-authored-by:  Tomás Maritano <tomymaritano@gmail.com>
@coderabbitai

coderabbitai Bot commented Aug 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@tomymaritano, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 23 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ae9983bc-33d0-4641-86e8-6fbaaaa379bd

📥 Commits

Reviewing files that changed from the base of the PR and between 2475850 and 30c92c1.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • .github/workflows/pr-title.yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tomymaritano
tomymaritano marked this pull request as ready for review August 22, 2026 04:07
@tomymaritano
tomymaritano merged commit 0cd3d25 into develop Aug 22, 2026
19 checks passed
@tomymaritano
tomymaritano deleted the cursor/fix-dependabot-e2e-https-27d2 branch August 22, 2026 04:11
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 0.16.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

cursor Bot pushed a commit that referenced this pull request Aug 22, 2026
## Summary

Documents the MCP / other-AI plan in a new folder `docs/ai/` (plan only,
no product code).

- `docs/ai/README.md` index
- `docs/ai/mcp-plan.md` Inkdrop shape: local HTTP after AuthGate + one
MCP; Grok Bot / Claude / Cursor share it
- `docs/ai/updates.md` 22 Aug decisions (AuthGate stays, #541/#552,
Project 3, no CouchDB, mobile Later)

Does not implement MCP HTTP. Existing `packages/mcp-server` stays as the
current stdio path.

## Test plan

- [ ] Read the three files on the PR
- [ ] Confirm no app/CI files changed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Now: unstick Dependabot e2e (fails in ~20s)

2 participants