Skip to content

fix(desktop): quiet chrome hover off teal fill and cream wash - #644

Merged
github-actions[bot] merged 1 commit into
developfrom
fix/quiet-chrome-hover
Sep 1, 2026
Merged

fix(desktop): quiet chrome hover off teal fill and cream wash#644
github-actions[bot] merged 1 commit into
developfrom
fix/quiet-chrome-hover

Conversation

@tomymaritano

@tomymaritano tomymaritano commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Light hover was cream plus a teal accent pill. Rows also lunged 6–8px.

  • Hover wash is `--bg-hover`
  • Detail chevron hover is a wash, not accent fill
  • GSAP travel is 2px / 3px

Squash-merge.

Summary by CodeRabbit

  • Style
    • Refined sidebar and note-list hover states with a more consistent neutral background.
    • Updated detail-button hover states for clearer, less prominent visual feedback.
  • User Experience
    • Reduced hover and press movement for subtler, smoother interactions.
  • Documentation
    • Added a research log entry documenting the updated hover behavior.

Row hover uses --bg-hover. The detail chevron is no longer an accent
pill. GSAP travel is 2px / 3px instead of 6 / 8.
@github-actions
github-actions Bot enabled auto-merge (squash) September 1, 2026 03:39
@github-actions github-actions Bot added the size/S label Sep 1, 2026
@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: c77d5490-f694-4cd3-af54-7e253a08c720

📥 Commits

Reviewing files that changed from the base of the PR and between fbc2717 and a4c4452.

📒 Files selected for processing (7)
  • apps/desktop/src/renderer/components/NoteList.module.css
  • apps/desktop/src/renderer/components/sidebar/sidebar.module.css
  • apps/desktop/src/renderer/motion/__tests__/chromePress.test.ts
  • apps/desktop/src/renderer/motion/__tests__/gsapRuntime.test.ts
  • apps/desktop/src/renderer/motion/chromePress.ts
  • apps/desktop/src/renderer/motion/gsapRuntime.ts
  • docs/research/2026-08-28-electron-ux-quality.md

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The desktop UI now uses neutral hover backgrounds for notes, sidebar rows, notebook rows, and detail controls. Chrome hover and press motion travel changed to 2px and 3px, with updated tests and research documentation.

Changes

Quiet hover interaction

Layer / File(s) Summary
Neutral hover styling
apps/desktop/src/renderer/components/NoteList.module.css, apps/desktop/src/renderer/components/sidebar/sidebar.module.css, docs/research/2026-08-28-electron-ux-quality.md
Note and sidebar hover states now use var(--bg-hover). Selected rows keep their selected state. Detail controls use neutral hover colors. The research log records the update.
Reduced chrome motion
apps/desktop/src/renderer/motion/chromePress.ts, apps/desktop/src/renderer/motion/gsapRuntime.ts, apps/desktop/src/renderer/motion/__tests__/*
Chrome hover travel changed to 2px. Chrome press travel changed to 3px. Tests now expect the updated offsets.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to a4c44

This change only quiets desktop hover styling and reduces small row animations; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 4 files. (3 skipped: 3 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the hover styling changes, including removal of the teal accent fill and cream wash. It does not mention the reduced row travel, but it clearly identifies a major part o…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title accurately describes the hover styling changes, including removal of the teal accent fill and cream wash. It does not mention the reduced row travel, but it clearly identifies a major part of the pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 4 files. (3 skipped: 3 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/quiet-chrome-hover

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions
github-actions Bot merged commit eca6917 into develop Sep 1, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant