Skip to content

Newlines / Carriage in header values violate HTTP header spec. Will break HTTP/2 #565

Description

@jimhooker2002

With headers such as CSP, they tend to be long and hence people naturally break them over multiple lines in config. That then breaks the service as headers with newline/carriage return violate HTTP spec. Seems especially troublesome in HTTP/2.

Attached patch will sanitize the headers and remove the offending characters.

patchfile.txt

(Sorry about the patchfile, didn't have permissions to create a branch and PR etc. The fix is very simple however.)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions