Skip to content

Add constructor parameter to disable CA pinning - #55

Merged
AaronAtDuo merged 1 commit into
mainfrom
ca_pinning
Jul 23, 2026
Merged

AaronAtDuo merged 1 commit into
mainfrom
ca_pinning

Conversation

@cisco-annikiti

@cisco-annikiti cisco-annikiti commented Jul 17, 2026 •

Copy link
Copy Markdown
Contributor

Description

Add enableCAPinning option to ClientOptions constructor parameter (default: true).
When disabled, the HTTPS agent validates via OS trust store instead of pinned CAs.
rejectUnauthorized: true is always explicitly set to ensure TLS verification cannot be bypassed regardless of the pinning setting.

Motivation and Context

Provides a configuration option to disable CA pinning for customers who cannot upgrade during a CA bundle transition.

How Has This Been Tested?

Added unit tests covering:

  • CA pinning is enabled by default
  • CA pinning can be disabled via constructor parameter
  • TLS verification is still enforced when CA pinning is disabled

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@cisco-annikiti
cisco-annikiti marked this pull request as ready for review July 23, 2026 15:52
@AaronAtDuo
AaronAtDuo merged commit 7792ebd into main Jul 23, 2026
2 checks passed
@AaronAtDuo
AaronAtDuo deleted the ca_pinning branch July 23, 2026 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants