Skip to content

build-extension.sh ships a stale backend.assemblyDir when you bump version #10

Description

@bennett-elder

manifest.json has two fields that have to agree: version, and backend.assemblyDir, which is <id>/<version>/backend. Nothing keeps them in sync and the build doesn't check.

scripts/build-extension.sh:218 rewrites sdkVersion and passes assemblyDir through as-is:

jq --arg v "$SDK_VER" '.sdkVersion = $v' "$DIR/manifest.json" > "$PKG/manifest.json"

.claude/skills/duplo-extension-dev/reference/02-authoring-guide.md:83 says to bump version on every backend code change. It doesn't say to bump assemblyDir. Follow that literally and you ship a bundle whose assemblyDir points at a directory the bundle doesn't contain.

What breaks depends on the target host:

  • Host already has the old version on disk: the install succeeds, the frontend updates, and the old backend DLL keeps running. No error anywhere.
  • Host has never seen the old version: the install fails with Extension entry assembly not found: /data/ai-helpdesk/extension-studio/<id>/<old version>/backend/<dll>. The tell is that the version in the path is older than the one being installed.

Repro: take a sample extension from the repo, bump the version, leave the assemblyDir the same, then build and install on a host which has never seen that extension.

The samples are all pinned at 0.1.0, so they're consistent today and nobody hits this until they bump something.

Fix belongs in the build script. assemblyDir is always <id>/<version>/backend, so derive it at bundle time instead of trusting the checked-in value.

Not a loader bug. ExtensionStudioLoader treats assemblyDir as an arbitrary relative path under the studio root, validates it against traversal, and throws when the file is missing. That's correct, and the test fixtures depend on it.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions