Skip to content

Derive the manifest's versioned paths from id and version at build time #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aboutte merged 2 commits into from
Sep 29, 2026
Merged

Derive the manifest's versioned paths from id and version at build time #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e779b0
fix(scripts): derive backend.assemblyDir from id and version
bennett-elder Sep 25, 2026
33b5057
fix(scripts): derive skills[].folder from id and version
bennett-elder Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .claude/skills/duplo-extension-dev/reference/02-authoring-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,11 @@ Ties the bundle together. For a typed extension (see the hello-world manifest):
}
```
Critical: `archetype` must be `"typed"` so the loader takes the DLL path; the five `*Type` names must be the
fully-qualified type names in your DLL; `backend.assemblyDir` is `<id>/<version>/backend`. **Bump `version` on
every backend code change** ([06](06-registration.md#reloading-changed-code--bump-manifestversion)).
fully-qualified type names in your DLL; `backend.assemblyDir` is `<id>/<version>/backend` and each
`skills[].folder` is `<id>/<version>/skills/<name>`. **Bump `version` on every backend code change**
([06](06-registration.md#reloading-changed-code--bump-manifestversion)) — you don't have to bump either path
with it, since `build-extension.sh` derives both from `id` and `version` when it writes the bundle manifest.
It prints a `NOTE:` if a checked-in value disagreed.

### Naming

Expand Down
36 changes: 34 additions & 2 deletions scripts/build-extension.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,8 +214,40 @@ echo " host provides $(wc -l < "$PROVIDED" | tr -d ' ') assemblies (excluded
echo "==> Assembling bundle"
PKG="$DIR/dist/pkg"
rm -rf "$PKG"; mkdir -p "$PKG/backend" "$PKG/fe" "$PKG/skills"
# Bundle manifest with the real host SDK version pinned in.
jq --arg v "$SDK_VER" '.sdkVersion = $v' "$DIR/manifest.json" > "$PKG/manifest.json"
# Bundle manifest with the real host SDK version pinned in, and both <id>/<version>/ paths derived from
# id+version. The host stages the bundle to <ExtensionStudioPath>/<id>/<version>/ but reads the entry assembly
# from backend.assemblyDir and each provisioning skill from skills[].folder, so all three have to agree.
# Maintained by hand they drift the moment you bump version alone, and what that breaks depends on the target:
#
# backend.assemblyDir a host that still has the old version on disk keeps running the OLD backend DLL and
# says nothing; a host that's never seen it refuses the install outright with
# "Extension entry assembly not found: .../<old version>/backend/<dll>".
# skills[].folder quieter in both directions. The loader's seeder returns early on a missing directory,
# so a fresh host loads fine with the skill silently absent — Agent-mode provisioning
# then fails later with a confusing "no skill" — and a host holding the old version
# seeds the OLD skill.
#
# Both are always <id>/<version>/…, so compute them here instead of trusting the checked-in values. The skill
# tail varies per entry (skills/<name>), so only the first two segments are replaced; a manifest with no
# skills array is left alone rather than given an empty one.
jq --arg v "$SDK_VER" '
.sdkVersion = $v
| .backend.assemblyDir = (.id + "/" + .version + "/backend")
| .id as $i | .version as $r
| if (.skills | type) == "array" then
.skills = [ .skills[]
| if ((.folder | split("/") | length) > 2)
then .folder = ($i + "/" + $r + "/" + (.folder | split("/") | .[2:] | join("/")))
else . end ]
else . end
' "$DIR/manifest.json" > "$PKG/manifest.json"
# Report drift rather than repairing it silently, so the checked-in value gets fixed at the source too.
_ad_src=$(jq -r '.backend.assemblyDir // ""' "$MANIFEST")
_ad_out=$(jq -r '.backend.assemblyDir' "$PKG/manifest.json")
[ "$_ad_src" = "$_ad_out" ] || echo " NOTE: stale backend.assemblyDir '$_ad_src' in $MANIFEST — bundled as '$_ad_out'"
_sk_src=$(jq -r '[.skills[]?.folder] | join(", ")' "$MANIFEST")
_sk_out=$(jq -r '[.skills[]?.folder] | join(", ")' "$PKG/manifest.json")
[ "$_sk_src" = "$_sk_out" ] || echo " NOTE: stale skills[].folder '$_sk_src' in $MANIFEST — bundled as '$_sk_out'"
# Ship only backend assemblies the host does NOT already provide, plus each kept DLL's sidecars. Native
# runtimes/ are host-provided too (Mongo/AWS natives load via the host's Default-ALC copies), so skip them.
kept=0; dropped=0
Expand Down
Loading