Repository navigation
Extension release checks: per-SDK tags at the built commit, sdkDigest, pinned builder, PR warnings - #16
Merged
Conversation
…the built commit, sdkDigest stamp, pinned builder, PR warnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: DUPLOAI-3667
Heads up: this changes
.env.example.BUILDER_TAG=latestis now commented out, because the default builder image is pinned by digest. A.envthat still setsBUILDER_TAG=latestkeeps building with:latest, so nothing breaks for existing users.What
These are general release checks for extension repos. Every repo gets them at its next devkit upgrade. Checks on a PR only warn. Only the release job refuses a release that cannot ship.
scripts/release-extensions.shreplaces the inline publish step inrelease.yml. It tags each release[name]-v[version]-sdk-[sdkVersion]with--target "$GITHUB_SHA". It readssdkVersionfrom the built bundle.[name]-v[version]tag count too. An unchanged version gets its missing per-SDK build published.immutableflag and warns when the release landed mutable.sdkDigest.build-extension.shstampssdkDigestbesidesdkVersionin the bundle manifest. It is the sha256 of the SDK feed the bundle compiled against, andscripts/_sdk_digest.shdefines it. The digest is computed from a fresh extraction of the SDK bundle, sincebackend/sdk-packages/accumulates packages from earlier builds._builder.shanddocker-compose.ymldefault toduplo-extension-builder@sha256:8185e6a7…, which is the current:latest.BUILDER_TAGandBUILDER_IMAGEstill override it.builder-image.ymlprints the new digest after each publish, so a toolchain move is a reviewed one-line PR.scripts/check-extension-pr.shruns inextension-ci.ymlon pull requests. For each changed extension it warns about three things. The first is a change with nomanifest.versionbump. The second is a shipped skill with noskills[].folderentry. The third is a webpack frontend (fe/remoteEntry.jswith noremoteEntry.json).release.yml. The setup-dotnet and setup-node steps are dropped, because the build runs in the builder container.Why
The DuploCloud upgrader delivers extensions from these releases. It pins each bundle by digest and picks the build whose
sdkVersionmatches the host. A mutable release, a tag on the wrong commit, or a rebuild at an unchanged version would each break that. The fixes land here and not in each repo, becauseupgrade_dev_kit.shoverwrites.github/andscripts/in every adopted repo.How it was verified
tests/test-release-extensions.sh,tests/test-check-extension-pr.sh,tests/test-sdk-digest.shandtests/test-builder-image.sh. The release and PR scripts run against a throwaway git repo with a stubbedgh. The digest is checked against an independent Python computation.build-extension.shthis PR does not change.sdkDigestand the warnings on a real build.