Skip to content

ng22 migration skill: expose the kept NgModule, and drop a remoteEntry query - #23

Merged
aboutte merged 1 commit into
duplocloud:devfrom
amaechiabuah:ng22-skill-exposes-and-query
Oct 2, 2026
Merged

aboutte merged 1 commit into
duplocloud:devfrom
amaechiabuah:ng22-skill-exposes-and-query

Conversation

@amaechiabuah

Copy link
Copy Markdown
Contributor

Two fixes to the duplo-extension-ng22-migration skill, found migrating duploai-extension-eks-upgrade (its PR #9).

What

  • Step 2 now repoints exposes at the kept NgModule. The step copies helloworld's federation.config.js verbatim, but helloworld has been modernized to standalone components, so it exposes ./src/app/extension.routes.ts. Step 5 keeps the extension's extension.module.ts, and an extension coming off Angular 15 has no extension.routes.ts, so the build failed at config load with FsPath: …/src/app/extension.routes.ts does not exist. Step 2 now changes the exposed path along with the container name.
  • Step 7 now drops a ?v= cache-buster from remoteEntry. The substitution only matched a manifest ending in /remoteEntry.js". eks-upgrade's ended in remoteEntry.js?v=0.6.118, so it matched nothing, and the gate then requires remoteEntry to end in /remoteEntry.json. The substitution now takes an optional query, and a grep confirms the edit landed.

Docs only. No script or sample changes.

How it was verified

  • Both commands, extracted from the edited file, run against helloworld's federation.config.js and eks-upgrade's pre-migration manifest. The config ends up exposing ./src/app/extension.module.ts, and remoteEntry.js?v=0.6.118 becomes /remoteEntry.json.
  • The eks-upgrade migration that used these two changes built, passed verify-remote-federation.js, and released as eks-upgrade-v0.7.0-sdk-1.0.6.

@aboutte
aboutte changed the base branch from main to dev October 2, 2026 19:42
@amaechiabuah
amaechiabuah force-pushed the ng22-skill-exposes-and-query branch from 41a0c54 to 46538b6 Compare October 2, 2026 19:59
@aboutte
aboutte merged commit d3e8dc6 into duplocloud:dev Oct 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants