ng22 migration skill: expose the kept NgModule, and drop a remoteEntry query - #23
Merged
Merged
Conversation
amaechiabuah
force-pushed
the
ng22-skill-exposes-and-query
branch
from
October 2, 2026 19:59
41a0c54 to
46538b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes to the
duplo-extension-ng22-migrationskill, found migratingduploai-extension-eks-upgrade(its PR #9).What
exposesat the kept NgModule. The step copies helloworld'sfederation.config.jsverbatim, but helloworld has been modernized to standalone components, so it exposes./src/app/extension.routes.ts. Step 5 keeps the extension'sextension.module.ts, and an extension coming off Angular 15 has noextension.routes.ts, so the build failed at config load withFsPath: …/src/app/extension.routes.ts does not exist. Step 2 now changes the exposed path along with the container name.?v=cache-buster fromremoteEntry. The substitution only matched a manifest ending in/remoteEntry.js". eks-upgrade's ended inremoteEntry.js?v=0.6.118, so it matched nothing, and the gate then requiresremoteEntryto end in/remoteEntry.json. The substitution now takes an optional query, and agrepconfirms the edit landed.Docs only. No script or sample changes.
How it was verified
federation.config.jsand eks-upgrade's pre-migration manifest. The config ends up exposing./src/app/extension.module.ts, andremoteEntry.js?v=0.6.118becomes/remoteEntry.json.verify-remote-federation.js, and released aseks-upgrade-v0.7.0-sdk-1.0.6.