Skip to content

fix(cc): morph tile size when dragging across quick tiles - #4341

Merged
purian23 merged 3 commits into
duxlabs-dev:masterfrom
hthienloc:fix/cc-quick-tiles-drag-morph
Nov 20, 2026
Merged

purian23 merged 3 commits into
duxlabs-dev:masterfrom
hthienloc:fix/cc-quick-tiles-drag-morph

Conversation

@hthienloc

@hthienloc hthienloc commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

Description

Morph dragged CC tiles smoothly between Quick Tiles compact pills and full grid tile sizes when dragging across the Quick Tiles group boundary.

  • Dragging out of Quick Tiles: expands the lifted member to match its grid tile dimensions (columns, rows, compact, small, bare: false) centered on the cursor, matching the grid drop placeholder.
  • Dragging into Quick Tiles: shrinks the hovered grid tile to the group's quick-tile pill dimensions (compact, small, bare: membersBare) and hides the outer edit chrome.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
recording_2026-11-20_13-27-45.mp4

@github-actions github-actions Bot added fix ui Quickshell UI under quickshell/ labels Nov 20, 2026
@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Claude review

Two issues to fix before merge.

  • groupAt() now reads hoverGroup, whose own binding calls groupAt(), causing a binding loop on every group enter/leave: quickshell/Modules/ControlCenter/Components/CcTileGrid.qml:128
  • The re-entry inset applies on the first moveLifted() from lift(), so presses near the edge of a small group lift the member out of the group: quickshell/Modules/ControlCenter/Components/QuickTilesGroup.qml:90

Checked: CcTileGrid/CcTileSlot/QuickTilesGroup morph sizing, hysteresis, drop paths in ControlCenterContent, Theme tokens, D* widgets, idle cost. Model: claude-opus-5-5.

@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Claude review

The earlier binding loop and lift-edge issues are fixed, but the new sticky hysteresis is applied inconsistently, and that can delete a tile.

  • dropFromGrid (line 623) calls groupAt without the sticky id, so releasing inside the hysteresis band deletes the tile instead of grouping it: quickshell/Modules/ControlCenter/ControlCenterContent.qml:514
  • hoveredGroup leaves out the sticky id, so the tile reverts to full size inside the band while the drop still targets the group: quickshell/Modules/ControlCenter/Components/CcTileSlot.qml:157

Checked: sticky hoverGroup handler (no loop), dropSlot seeding on lift, out-of-group member sizing, drop/carry paths in ControlCenterContent, Theme tokens, idle cost. Model: claude-opus-5-5.

@hthienloc
hthienloc marked this pull request as draft November 20, 2026 06:35
@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Claude review

No issues found. The latest commit drops the sticky hysteresis, so the two findings from the previous run no longer apply: hoveredGroup, hoverGroup and dropFromGrid all call groupAt the same way again.

Checked: CcTileSlot group-hover morph (groupAt returns the group item so membersBare resolves, quickWidth has no width dependency, chrome hidden while hovering), QuickTilesGroup outside sizing against externalGhostSize/previewExternal centering, lift/drop paths, Behavior gating, Theme tokens, idle cost (bindings short-circuit when not dragging). Model: claude-opus-5-5.

@hthienloc
hthienloc marked this pull request as ready for review November 20, 2026 06:47
@purian23
purian23 merged commit 7147eec into duxlabs-dev:master Nov 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix ui Quickshell UI under quickshell/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants