Skip to content

shell: add optional rounded screen corners - #4342

Open
elzastrelitzia wants to merge 5 commits into
duxlabs-dev:masterfrom
elzastrelitzia:master
Open

elzastrelitzia wants to merge 5 commits into
duxlabs-dev:masterfrom
elzastrelitzia:master

Conversation

@elzastrelitzia

Copy link
Copy Markdown

Description

Adds per-monitor corner wedges with off/always/unlessFullscreen modes, lock-screen wedges, and a settings row.

Uses Theme tokens and existing compositor fullscreen helpers. The new screenCornerMode setting defaults to off.

Each physical screen gets four small overlay layer wedges with an empty input region and ExclusionMode.Ignore, so corners never take clicks or reserve screen edges. Radius and color follow the active theme instead of adding duplicate settings.

Fullscreen visibility uses the existing CompositorService helpers, including the Niri path. No new dependencies, timers, or background processes.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that changes existing behavior)
  • Refactor / internal cleanup
  • Documentation
  • Other

Related issues

Closes #4280

Screenshots / video

Video_2026-11-20_14-01-40.mp4

Checklist

  • My code follows the conventions in CONTRIBUTING.md
  • I have tested my changes locally
  • New user-facing strings are wrapped in I18n.tr() with translator context, reusing existing terms where possible
  • Go changes: ran make fmt, added/updated tests, make test passes, and go mod tidy is clean
  • QML changes: ran make lint-qml with no new warnings
  • I have opened a corresponding pull request in dux-docs to document any new behaviors: https://github.com/duxlabs-dev/dux-docs

Adds per-monitor corner wedges with off/always/unlessFullscreen modes,
lock-screen wedges, and a settings row.

Uses Theme tokens and existing compositor fullscreen helpers.
@github-actions github-actions Bot added feature ui Quickshell UI under quickshell/ labels Nov 20, 2026
@purian23

Copy link
Copy Markdown
Member

/claude review

@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Claude review

Looks good. One small reuse fix in the settings row.

  • Use the values/value/onValueSelected mapping that SettingsButtonGroupRow already has instead of hand-written index ternaries, quickshell/Modules/Settings/ThemeSurfacesTab.qml:327
    Docs pending: new screenCornerMode setting (no dux-docs PR linked)
    Checked: the corner layer windows (empty input mask, Ignore exclusion, sizes of 0 clamped to 1 by dux-qt-base), the fullscreen helpers and their signatures, the Theme tokens, the lock screen corners, the settings spec and profile map, reuse of the "Off"/"On" catalog terms, the search index, and the tests. Model: claude-opus-5-5.

@Conava

Conava commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

The screen corners can already be adjusted with a different setting that controls all corners of the shell.

It might be a good idea to group those settings together and to put these new ones behind one toggle like "Override screen corners" to not clutter the settings for people who dont want to use this.

Good work so far!

elzastrelitzia and others added 2 commits November 20, 2026 15:13
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@purian23

Copy link
Copy Markdown
Member

/claude review

@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Claude review

Close to ready. One problem: the new override toggle cannot be found in settings search.

  • The "Override screen corners" card has no settingKey, so it is missing from the search index and search only points at the collapsed child rows, quickshell/Modules/Settings/ThemeSurfacesTab.qml:353
    Docs pending: new screenCornerMode and screenCornerRadius settings (no dux-docs PR linked)
    Checked: the new toggle card, button group and radius slider, catalog term reuse ("Corner radius", "Square", "Mode", "On"), the radius fallback in RoundCorner, the lock screen corners, the corner layer windows and fullscreen helpers, the settings spec, profile map and search index, and the tests. Model: claude-opus-5-5.

@elzastrelitzia

Copy link
Copy Markdown
Author

OH, I FORGOR TO ADD IT

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature ui Quickshell UI under quickshell/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add rounded screen corners (screen edge rounding) as an optional overlay

3 participants