Skip to content

ci: set repo in release workflow #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dwilding merged 2 commits into from
Sep 18, 2026
Merged

ci: set repo in release workflow #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4cd5bf
ci: pass --repo to gh commands in wait-checks
dwilding Sep 18, 2026
346405a
ci: pass --repo to gh commands in create-draft
dwilding Sep 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion .github/scripts/write_release_notes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,18 @@ def gh(*args: str) -> str:


def latest_tag() -> str:
return gh("release", "list", "-L", "1", "--json", "tagName", "-q", ".[0].tagName")
return gh(
"release",
"list",
"--repo",
os.environ["GITHUB_REPOSITORY"],
"-L",
"1",
"--json",
"tagName",
"-q",
".[0].tagName",
)


def merged_prs() -> list[dict]:
Expand All @@ -25,6 +36,8 @@ def merged_prs() -> list[dict]:
prs = gh(
"pr",
"list",
"--repo",
repo,
"--state",
"merged",
"--base",
Expand Down
12 changes: 7 additions & 5 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,25 +55,26 @@ jobs:
steps:
- name: Wait for checks
id: wait
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
REPO: ${{ github.repository }}
run: |
set -euo pipefail
sha="${{ github.sha }}"
release=false
# Wait for all other workflow runs on this SHA to complete.
other_runs="$(gh run list --branch main --limit 50 --json databaseId,headSha --jq ".[] | select(.headSha == \"${sha}\") | .databaseId")"
other_runs="$(gh run list --repo "$REPO" --branch main --limit 50 --json databaseId,headSha --jq ".[] | select(.headSha == \"${sha}\") | .databaseId")"
other_runs="$(echo "$other_runs" | grep -v "${{ github.run_id }}" || true)"
all_passed=true
for run in $other_runs; do
if ! gh run watch "$run" --exit-status >/dev/null 2>&1; then
if ! gh run watch "$run" --repo "$REPO" --exit-status >/dev/null 2>&1; then
all_passed=false
fi
done
if [[ "$all_passed" == "true" ]]; then
release=true
fi
echo "release=$release" >> "$GITHUB_OUTPUT"
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

create-draft:
runs-on: ubuntu-latest
Expand All @@ -88,7 +89,8 @@ jobs:
env:
VERSION: ${{ needs.check-version.outputs.version }}
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
REPO: ${{ github.repository }}
run: |
set -euo pipefail
notes="$(uv run --script .github/scripts/write_release_notes.py "$VERSION")"
gh release create "$VERSION" --draft --target main --notes "$notes"
gh release create "$VERSION" --repo "$REPO" --draft --target main --notes "$notes"
Loading