Skip to content

Add spacing between the mobile fixed header and the page title (#763) - #953

Merged
jjroelofs merged 1 commit into
8.xfrom
jur/8.x/763-mobile-fixed-header-title-spacing
Oct 28, 2026
Merged

jjroelofs merged 1 commit into
8.xfrom
jur/8.x/763-mobile-fixed-header-title-spacing

Conversation

@jjroelofs

Copy link
Copy Markdown
Collaborator

Linked issues

Solution

With the mobile fixed header on and no admin toolbar, the body padding equals the header height, so the page title starts at the header edge. The padding now adds 16px (1rem in the compiled CSS) of space. Logged-in users with a toolbar are unchanged. Compiled CSS rebuilt with the Docker build.

Checklist

  • I have read the CONTRIBUTING.md document.
  • My commit messages follow the contributing standards and style of this project.
  • My code follows the coding standards and style of this project.
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Need to run update.php after code changes
  • Requires a change to end-user documentation.
  • Requires a change to developer documentation.
  • Requires a change to QA tests.
  • Requires a new QA test.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@jjroelofs jjroelofs left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed commit dafa380 against 8.x. No actionable findings.

The selector adds the requested spacing for mobile fixed headers without an admin toolbar. The existing toolbar-specific rules remain intact, and the build correctly converts the added 16px to 1rem. The other compiled CSS changes use equivalent color notation for the existing shadows.

Validation: SCSS stylelint passed locally. Recompiled the changed SCSS with Sass, Autoprefixer, and the repository's px-to-rem settings; all 147 CSS declarations match the committed CSS after normalizing those equivalent colors. All five reported CI checks passed. Reviewed the surrounding header styles, template, and JavaScript; a live Drupal/browser visual check was not run.

@jjroelofs
jjroelofs merged commit 58b50f2 into 8.x Oct 28, 2026
5 checks passed
@jjroelofs
jjroelofs deleted the jur/8.x/763-mobile-fixed-header-title-spacing branch October 28, 2026 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant