Repository navigation
Conversation
The admin palette and font generators POST to dxpr_theme_helper routes that now require the X-CSRF-Token header. Fetch the token from session/token and send it with each request. Rebuilt the settings admin bundle. Refs dxpr/dxpr_theme_helper#55
The new token fetch pushed lines past the 80 column limit, so the eslint prettier rule failed in CI. Reformat both files to match prettier. No behaviour change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The admin palette and font generators now fetch a CSRF token from
session/tokenand send it asX-CSRF-Token. This is needed becausedxpr_theme_helpernow requires that header ongenerate-paletteandgenerate-fonts.Merge this PR before dxpr/dxpr_theme_helper#55.
Linked issues
Refs dxpr/dxpr_theme_helper#55
Testing
theme-settings-colors.jsandtheme-settings-fonts.jswere edited; the settings admin bundle was rebuilt withnpm run build(only the settings admin bundle changed in the diff).