LoTW/ADIF export dialog: show submode instead of parent mode - #1134
Open
yl3gbc wants to merge 1 commit into
Open
LoTW/ADIF export dialog: show submode instead of parent mode#1134yl3gbc wants to merge 1 commit into
yl3gbc wants to merge 1 commit into
Conversation
getQSODetailsForLoTWDownload() joined the mode table on log.modeid, which is the parent ADIF mode: MFSK covers both FT4 and FT8, so every FT4 and FT8 QSO showed up as 'MFSK' in the export dialog. Join on log.submode instead, the same way the log view was fixed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getQSODetailsForLoTWDownload() joined the mode table on log.modeid, which is the parent ADIF mode: MFSK covers both FT4 and FT8, so every FT4 and FT8 QSO showed up as 'MFSK' in the export dialog. Join on log.submode instead, the same way the log view was fixed.