Repository navigation
Conversation
_get_triple_count treated a graph which is not in the graph list as a graph with zero triples. When the deployment loses the result graph during a validation - which happens intermittently, reproducibly, and is not a plugin problem - the test reported it as "assert 0 == 16", an assertion about numbers which says nothing about what actually went wrong. The helper now fails with the graph IRI instead, and the pre-condition of test_safe_as_graph, which is what the zero was really there for, is written as the membership check it always was. The message on the first count assertion said "result graph should be empty" while asserting the opposite. No changelog entry: nothing here changes what a user of the plugin sees. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SxhW9xhADjcpzFezfXBBDk
Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The check on
mainwent red ontest_safe_as_graphwithassert 0 == 16, which reads as the validation wrote no results. It was not that. The result graph had vanished from the deployment, and_get_triple_countreturned0for it because a graph missing from the graph list was indistinguishable from an empty one:Reproduced against a local deployment — the batch reports
FINISHED, yet the graph is gone and stays gone:It is intermittent (the same probe run again wrote its 48 triples normally) and it is not a plugin problem. But the assertion made it look like one, and cost a diagnosis to tell apart.
What
_get_triple_countnow callspytest.failnaming the graph, so the failure readsGraph <http://docker.localhost/results/> does not exist in the deploymentinstead ofassert 0 == 16.test_safe_as_graphthat the zero was really serving is written as the membership check it always was.> 0.No changelog entry — nothing here changes what a user of the plugin sees.
Still open
validate_graph/task.py:180breaks out of the poll loop on any status that is notSCHEDULED/RUNNING,ERRORincluded, then reports "Found N Violations" as success. A batch failing server-side yields an empty result graph and a green workflow task. Not touched here — it is a user-visible plugin bug and wants its own change and changelog entry.🤖 Generated with Claude Code
https://claude.ai/code/session_01SxhW9xhADjcpzFezfXBBDk