Repository navigation
fix: distinguish interrupted tool calls from completion - #48
Merged
johnnyhuy merged 1 commit intoNov 10, 2026
Merged
Conversation
Co-authored-by: OpenAI Codex <noreply@openai.com>
johnnyhuy
deleted the
ao/pidex-development-2/agent/issue-47-interrupted-tools
branch
November 10, 2026 17:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfinished tool calls now show Interrupted instead of Done in saved history, and active cards settle to Interrupted when the agent stops or its runtime exits. Partial output remains available, completed and failed calls retain their outcomes, and a late completion result clears the interrupted state.
Cards explain that a missing completion result does not establish whether changes were made. Markdown exports use the same status and count interrupted calls separately.
Part of #2.
Closes #47.
Verified locally with the pinned mise toolchain on macOS
bun install --frozen-lockfilepassed.bun run lintandbun run typecheckpassed.bun run test:unitpassed, 87 tests.bun run test:integrationpassed, 48 tests.mise run buildpassed.mise exec -- bun run test:e2epassed, 44 tests across five suites.c2815bbbefore merge.Proof
.tmp/proof/e2e.logrecords the full Electron run..tmp/proof/interrupted-e2e.lognames the new stopped-tool scenario..tmp/proof/interrupted-tool.pngshows the expanded Interrupted card, warning and retained partial output. Visually inspected locally.test-results/workbench/10-interrupted-tool.pngin the existingpidex-e2eartefact..tmp/proof/focused-unit.logand.tmp/proof/focused-integration.logfor incomplete archives, empty completion results, late results, runtime exits, card wording and export counts.The Electron suite uses deterministic Pi RPC fixtures. Live provider execution is not covered, and interruption does not imply that tool effects were rolled back. Scratch proof files are not committed.