restrict deserialized classes when reading weaving cache index - #361
Open
nabhan06 wants to merge 1 commit into
Open
restrict deserialized classes when reading weaving cache index#361nabhan06 wants to merge 1 commit into
nabhan06 wants to merge 1 commit into
Conversation
Signed-off-by: sayed nabhan <nabhan@bugqore.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AbstractIndexedFileCacheBacking.readIndex deserializes the cache index with a bare ObjectInputStream, and that index lives under aj.weaving.cache.dir, a directory that can be shared between JVMs or users. Anyone who can write that file hands the weaver an arbitrary serialized graph and readObject builds it during load-time weaving, before the IndexEntry[] cast ever runs. Limit resolveClass to IndexEntry and its array so a tampered index is dropped before any foreign class is constructed, and the Default, Flat and Zipped backings all inherit the check.