Repository navigation
Conversation
The onboarding agent's dispose revokes the participant's credentials. The IssuerService (EDC 1.0) answers a revocation with 204, which the client reported as a failure, so the offboarding activity failed and the dispose ended in error although the credential was revoked. 200 and 204 both mean revoked.
|
|
||
| func TestHttpApiClient_RevokeCredential_NoContent(t *testing.T) { | ||
| server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| if r.URL.Path == "/v1/participants/test-issuer/credentials/test-credential-id/revoke" && r.Method == http.MethodPost { |
Contributor
There was a problem hiding this comment.
magic string - please either use a variable for test-credential-id or a wildcard (cf TestHttpApiClient_CreateHolder_ApiReturnsError)
Contributor
|
@ma3u you need to sign the ECA, otherwise we can't accept the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since #233 the onboarding agent revokes the participant's credentials when a VPA is disposed. The IssuerService answers the revocation with
204 No Content:revokeCredentialin its admin API is avoidJAX-RS method (IssuerCredentialsAdminApiController, L78-L86).HttpApiClient.RevokeCredentialaccepts only200. So the credential is revoked, but the client reportsreceived status code 204 with message [], the offboarding activity fails, and the participant profile ends disposed with an error.The client now accepts
200and204, with a test for204.How it was found
We onboarded and disposed a participant through the Tenant Manager on an EDC 1.0.0-RC6 stack (Connector, IdentityHub, IssuerService). With v0.0.8, dispose failed in the offboarding activity as described above. With this change the dispose completes, and the IssuerService reports the credential as revoked.