Conversation
vinokurig
requested review from
SDawley,
ibuziuk and
tolusha
as code owners
September 17, 2026 08:05
When both a personal access token and an OAuth token secret exist for the same SCM provider, the newest secret was used, so a freshly minted OAuth token shadowed the user configured PAT. OAuth tokens may be short-living, e.g. GitLab OAuth tokens expire in 2 hours, so the PAT with a longer expiration period has to be preferred. Order the resolved tokens to put the personal access ones first and keep their secrets during the forced OAuth token refresh cleanup. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
vinokurig
force-pushed
the
CRW-12749
branch
from
September 17, 2026 08:53
d21a5a6 to
f1e7d3a
Compare
|
Docker image build succeeded: quay.io/eclipse/che-server:pr-1066 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/cheServer/deployment", "value": {containers: [{image: "quay.io/eclipse/che-server:pr-1066", name: che}]}}]" |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: svor, vinokurig The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
/retest |
5 similar comments
Contributor
|
/retest |
Contributor
|
/retest |
Contributor
|
/retest |
Contributor
|
/retest |
Contributor
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When both a personal access token and an OAuth token secret exist for the same SCM provider, the newest secret was used, so a freshly minted OAuth token shadowed the user configured PAT. OAuth tokens may be short-living, e.g. GitLab OAuth tokens expire in 2 hours, so the PAT with a longer expiration period has to be preferred.
Order the resolved tokens to put the personal access ones first and keep their secrets during the forced OAuth token refresh cleanup.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
https://redhat.atlassian.net/browse/CRW-12749
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedRelease Notes
Reviewers
Reviewers, please comment how you tested the PR when approving it.