Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ibuziuk The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ibuziuk
left a comment
There was a problem hiding this comment.
@vinokurig @svor afaik java changes are actually dead code - wsplugins / jwtproxy are legacy, and we should probably have an issue for cleanup
Upgrade Fabric8 Kubernetes client to 7.9.0, which adds Kubernetes 1.37 model support and fixes WebSocket handling in the optional Vert.x 5 and Jetty transports. 7.9.0 adds a `bindMountOptions` field to `VolumeMount`, changing its canonical constructor signature. Replace the two positional `new VolumeMount(...)` call sites with `VolumeMountBuilder` so they are not coupled to the generated constructor arity. Fixes eclipse-che/che#23943 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Docker image build succeeded: quay.io/eclipse/che-server:pr-1068 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/cheServer/deployment", "value": {containers: [{image: "quay.io/eclipse/che-server:pr-1068", name: che}]}}]" |
|
/retest |
|
@ibuziuk: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Upgrade Fabric8 Kubernetes client to 7.9.0, which adds Kubernetes 1.37 model support and fixes WebSocket handling in the optional Vert.x 5 and Jetty transports.
7.9.0 adds a
bindMountOptionsfield toVolumeMount, changing its canonical constructor signature. Replace the two positionalnew VolumeMount(...)call sites withVolumeMountBuilderso they are not coupled to the generated constructor arity.Fixes eclipse-che/che#23943
What does this PR do?
Screenshot/screencast of this PR
What issues does this PR fix or reference?
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedRelease Notes
Reviewers
Reviewers, please comment how you tested the PR when approving it.