feat(oauth): add OAuth IDE redirect proxy for browser-based extensions - #1070
RomanNikitenko wants to merge 1 commit into
Conversation
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Assisted-by: Cursor AI
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: RomanNikitenko The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Docker image build succeeded: quay.io/eclipse/che-server:pr-1070 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/cheServer/deployment", "value": {containers: [{image: "quay.io/eclipse/che-server:pr-1070", name: che}]}}]" |
|
/retest |
|
@RomanNikitenko: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What does this PR do?
/api/oauth/ide-redirectendpoint on the Che server that acts as a redirect proxy: it receives the OAuth callback from the identity provider and forwards the authorization code to the originating workspace.Screenshot/screencast of this PR
What issues does this PR fix or reference?
https://redhat.atlassian.net/browse/CRW-11743
How to test this PR?
Gitlabaccount =>Applications=>Add new applicationRedirect URI:<instance for testing>/api/oauth/ide-redirectapi,read_api,read_userscopesConfidentialGitlabextension with my changes: https://gitlab.com/gitlab-org/gitlab-vscode-extension/-/merge_requests/3355VSIX: https://gitlab.com/rnikiten/gitlab-vscode-extension/-/blob/test-custom-redirect-uri/gitlab-workflow-6.90.6.vsix?ref_type=headsF1=>Install From VSIX=> Select theVSIXGitlabpanel =>Authenticate to Gitlab instance=>https://gitlab.com/=>OAuth=>Open=>Autorize <App name>=> Come back to the IDEBefore authenticaion:

After:

PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedRelease Notes
Reviewers
Reviewers, please comment how you tested the PR when approving it.
Assisted-by: Cursor AI