Find/replace overlay: toggle replace visibility instead of recreating it#4206
Draft
HeikoKlare wants to merge 1 commit into
Draft
Conversation
Creating and disposing the replace bar widgets on every toggle forced several call sites to guard against the bar not existing yet (open/close lifecycle methods, null-checks on replaceBar, a separate replace-action activation/deactivation path in the command support). Instead, create the replace bar once alongside the search bar and hide it the same way narrow overlays already hide their toolbars, via changing visibility and adapting the layout data. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The replace bar's widgets used to be created and disposed every time the replace toggle was clicked, which forced several call sites to guard against the bar not existing yet (open/close lifecycle methods, null-checks on
replaceBar, a separate replace-action activation/deactivation path in the command support).The replace bar is now created once, alongside the search bar, and hidden the same way narrow overlays already hide their toolbars: by toggling visibility and adapting the layout data, instead of disposing and recreating the widgets.