Skip to content

Prompt to save changes when closing Organize Favorites dialog#2825

Open
SougandhS wants to merge 1 commit into
eclipse-platform:masterfrom
SougandhS:AddClosingPrompt
Open

Prompt to save changes when closing Organize Favorites dialog#2825
SougandhS wants to merge 1 commit into
eclipse-platform:masterfrom
SougandhS:AddClosingPrompt

Conversation

@SougandhS

Copy link
Copy Markdown
Contributor

Prompt users to save changes before closing the Organize Favorites dialog when the favorites list has been modified. This prevents accidentally losing changes made to the favorites list when the dialog is closed without pressing OK.

Screenshot 2026-07-25 at 6 36 34 PM

Prompt users to save changes before closing the Organize Favorites
dialog when the favorites list has been modified. This prevents
accidentally losing changes made to the favorites list when the dialog
is closed without pressing OK.
@iloveeclipse

Copy link
Copy Markdown
Member

Why not simply save on OK, without dialog?

@SougandhS

SougandhS commented Jul 25, 2026

Copy link
Copy Markdown
Contributor Author

Why not simply save on OK, without dialog?

it saves on clicking Ok but on accidental ESC press or Cancel click it simply closes without saving, so added for those cases.

@github-actions

Copy link
Copy Markdown
Contributor

Test Results

    54 files  ±0      54 suites  ±0   1h 0m 9s ⏱️ + 3m 41s
 4 687 tests ±0   4 665 ✅ ±0   22 💤 ±0  0 ❌ ±0 
11 955 runs  ±0  11 802 ✅ ±0  153 💤 ±0  0 ❌ ±0 

Results for commit 7f6991d. ± Comparison against base commit df99636.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants