Remove all warnings features

[nradakovic]

All warnings features are now defined within score_cpp_policies so we have to remove them from here.

[Copilot]

Pull request overview

This PR removes the built-in warning-flag feature definitions from the Linux and QNX C/C++ toolchain templates, based on the assumption that warning features are now provided externally (e.g., via score_cpp_policies) rather than by this repository’s toolchain implementation.

Changes:

• Removed warning flag groups (minimal/strict/all/-Werror) from Linux and QNX cc_toolchain_flags.bzl.template.
• Removed corresponding warning features and flags.bzl loads from Linux and QNX cc_toolchain_config.bzl.template.
• Removed the warning features from the toolchain features = [...] lists so they’re no longer registered by default.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
templates/qnx/cc_toolchain_flags.bzl.template	Removes warning flag groups from the QNX flags template.
templates/qnx/cc_toolchain_config.bzl.template	Stops loading/defining warning features in the QNX toolchain config template.
templates/linux/cc_toolchain_flags.bzl.template	Removes warning flag groups from the Linux flags template.
templates/linux/cc_toolchain_config.bzl.template	Stops loading/defining warning features in the Linux toolchain config template.

Suppressed comments (1)

templates/qnx/cc_toolchain_config.bzl.template:545

• This removes the built-in warning features from the QNX toolchain (previously minimal_warnings was enabled by default). Any consumer using --features=minimal_warnings|strict_warnings|warnings_as_errors will now get an unknown-feature error unless those features are injected via extra_known_features/extra_enabled_features. The repo docs still describe these as toolchain-provided and note QNX defaults (docs/features.md:90-97; docs/migration_guide.md:98-113). Please update the docs/tests/examples to reflect the new injection requirement (e.g., via score_cpp_policies), or provide a compatibility shim that keeps these feature names registered.

    extra_compile_flags = %{extra_compile_flags}
    extra_compile_flags_feature = feature(
        name = "extra_compile_flags",
        enabled = %{extra_compile_flags_switch},

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Suppressed comments (1)

docs/test_suite.md:287

• The expected output block for the feature_verification_tests suite should reflect 12 executed tests (matching tests/BUILD), not 11.

  Executed 11 tests: 11 passed