mw/com: Add internal interfaces to architectural design - #1019
Open
bemerybmw wants to merge 2 commits into
Open
Conversation
bemerybmw
force-pushed
the
brem_safety_sentinel_interfaces
branch
from
August 28, 2026 07:56
0d587d0 to
2ca2a3f
Compare
Adds component_interaction diagrams to the static_view section of the architectural design which are subsets of the components which are selected to more clearly show the interfaces between the components. The actual interfaces are defined in the internal_interfaces directory. Note. These internal interfaces are intended to be high level, not a 1:1 mapping with C++ function names. Which interfaces exactly are required will be refined when creating sequence diagrams between the components so this current state is not final.
bemerybmw
force-pushed
the
brem_safety_sentinel_interfaces
branch
from
August 28, 2026 08:07
2ca2a3f to
32ddcea
Compare
LittleHuba
previously requested changes
Aug 28, 2026
LittleHuba
left a comment
LittleHuba
left a comment
Contributor
There was a problem hiding this comment.
No git_override at this moment please. Blocking until release candidate is through or we know that we must bump.
bemerybmw
marked this pull request as ready for review
September 1, 2026 10:52
bemerybmw
requested review from
castler,
crimson11,
hoe-jo and
limdor
as code owners
September 1, 2026 10:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.