lola: Move SkeletonAndServiceElements component code to subdir and split up bazel targets - #1023
Draft
bemerybmw wants to merge 6 commits into
Draft
lola: Move SkeletonAndServiceElements component code to subdir and split up bazel targets#1023bemerybmw wants to merge 6 commits into
bemerybmw wants to merge 6 commits into
Conversation
The new architectural design introduced a new set of units and components. Eventually, the code structure should more or less follow the design. As a first step, we move the classes corresponding to the lola SkeletonAndServiceElements component into a new subdirectory. We may decide later to further divide the code into one directory per unit.
bemerybmw
commented
Aug 28, 2026
| namespace score::mw::com::impl::lola | ||
| { | ||
|
|
||
| class ILolaSkeleton |
Contributor
Author
There was a problem hiding this comment.
Add documentation to class and also all functions in interfaces.
crimson11
requested changes
Aug 28, 2026
| /// \return A pair containing: | ||
| /// - An type erased pointer to the allocated data storage (void*). | ||
| /// - The EventDataControlComposite for managing the event's control data. | ||
| virtual GenericRegistrationResult RegisterGeneric(const ElementFqId element_fq_id, |
Contributor
There was a problem hiding this comment.
Signature will slightly change with my type-erasure PR ... then we will only have a Register (because there is no GenericEvent/Field anymore)
| tags = ["FFI"], | ||
| visibility = [ | ||
| "//score/mw/com/impl/bindings/lola:__pkg__", | ||
| "//score/mw/com/impl/bindings/lola:__subpackages__", |
Contributor
There was a problem hiding this comment.
Why do we have still the methods dir? It shall beall in skeleton_and_service_elements?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.