Enable core dump extraction for bigdata integration test by Tejaswini-Janjale25 · Pull Request #739 · eclipse-score/communication

Tejaswini-Janjale25 · 2026-07-22T06:14:06Z

Added changes to store core files when they are generated.

soldier-sky · 2026-07-22T12:08:27Z

-        env = {"DOCKER_HOST": ""},
+        env = {
+            "DOCKER_HOST": "",
+            "TEST_UNDECLARED_OUTPUTS_DIR": "$(TEST_UNDECLARED_OUTPUTS_DIR)",


can you use some better name for this env var?

This variable is already present at docker plugin, I am just reusing it

soldier-sky · 2026-07-22T12:18:09Z

+        _extend_list_in_kwargs(kwargs, "args", ["--extract-core"])
+        # Only pass --core-output-dir if explicitly specified by user
+        # Otherwise, the plugin will use TEST_UNDECLARED_OUTPUTS_DIR/cores at runtime
+        if core_output_dir != None:


should we validate that --extract-core or --core-output-dir points to valid directory?

added validation for core_output_dir

Static validation is good step to identify wrong path configuration i.e. obvious invalid paths. However canonical path validation can be good but with our use-case current checks seems good enough.

LittleHuba · 2026-07-30T08:19:27Z

    return kwargs

-def integration_test(name, srcs, filesystem, **kwargs):
+def integration_test(name, srcs, filesystem, extract_core = False, core_output_dir = None, **kwargs):


Making this an attribute is probably not the best idea.
I would prefer a bazel flag. But IMHO. This bool_flag should go into ITF directly.
Same for the extraction path (with a string_flag).

I have added code changes for this comment. However waiting for merging ITF related changes as after that I can remove git_override part from here.
eclipse-score/itf#124

LittleHuba · 2026-08-25T06:32:27Z

 # SPDX-License-Identifier: Apache-2.0
 # *******************************************************************************

-


Please avoid this empty line change.

Ok @LittleHuba. I will take care of this

LittleHuba · 2026-08-25T06:35:38Z

-        env = {"DOCKER_HOST": ""},
+        env = {
+            "DOCKER_HOST": "",
+            "TEST_UNDECLARED_OUTPUTS_DIR": "$(TEST_UNDECLARED_OUTPUTS_DIR)",


Please use env_inherit for this.
See https://bazel.build/reference/be/common-definitions#common-attributes

I have updated the code

feat(qnx): enable core dump extraction workflow

github-project-automation Bot added this to COM - Communication FT Jul 22, 2026

github-project-automation Bot moved this to Backlog in COM - Communication FT Jul 22, 2026

anmittag assigned Tejaswini-Janjale25 Jul 22, 2026

soldier-sky reviewed Jul 22, 2026

View reviewed changes

Tejaswini-Janjale25 force-pushed the teja_itf_test_allow_core_dump branch from 360752a to 65c78c3 Compare July 23, 2026 06:34

soldier-sky approved these changes Jul 24, 2026

View reviewed changes

LittleHuba reviewed Jul 30, 2026

View reviewed changes

Tejaswini-Janjale25 force-pushed the teja_itf_test_allow_core_dump branch 2 times, most recently from bee10cc to aa6e222 Compare August 5, 2026 07:42

Tejaswini-Janjale25 force-pushed the teja_itf_test_allow_core_dump branch 2 times, most recently from 8122b81 to 02da918 Compare August 25, 2026 06:07

Tejaswini-Janjale25 marked this pull request as ready for review August 25, 2026 06:10

Tejaswini-Janjale25 requested review from bemerybmw, castler, crimson11, hoe-jo and limdor as code owners August 25, 2026 06:10

LittleHuba reviewed Aug 25, 2026

View reviewed changes

Tejaswini-Janjale25 force-pushed the teja_itf_test_allow_core_dump branch 4 times, most recently from ba52284 to 686ca07 Compare August 26, 2026 04:51

Tejaswini-Janjale25 marked this pull request as draft August 26, 2026 04:52

Tejaswini-Janjale25 force-pushed the teja_itf_test_allow_core_dump branch from 686ca07 to d8430d1 Compare August 26, 2026 04:58

Enable core dump handling in integration_testing.bzl

1218e4d

Tejaswini-Janjale25 force-pushed the teja_itf_test_allow_core_dump branch from d8430d1 to 1dba45e Compare August 26, 2026 04:59

sahithi-nukala added the test-qnx Enables the checks with QNX toolchains. Checks require committer approval to start execution. label Aug 26, 2026

sahithi-nukala had a problem deploying to workflow-approval August 26, 2026 05:03 — with GitHub Actions Error

Tejaswini-Janjale25 marked this pull request as ready for review August 26, 2026 05:11

Tejaswini-Janjale25 force-pushed the teja_itf_test_allow_core_dump branch from 1dba45e to 373c59e Compare August 26, 2026 05:11

Tejaswini-Janjale25 deployed to workflow-approval August 26, 2026 05:11 — with GitHub Actions Active

Tejaswini-Janjale25 force-pushed the teja_itf_test_allow_core_dump branch from 373c59e to ccf9f45 Compare August 26, 2026 09:01

Tejaswini-Janjale25 deployed to workflow-approval August 26, 2026 09:01 — with GitHub Actions Active

Tejaswini-Janjale25 force-pushed the teja_itf_test_allow_core_dump branch from ccf9f45 to af3d4ad Compare August 26, 2026 12:49

Tejaswini-Janjale25 deployed to workflow-approval August 26, 2026 12:49 — with GitHub Actions Active

LittleHuba previously approved these changes Aug 27, 2026

View reviewed changes

Enable core dump extraction for bigdata integration test

fd44f42

feat(qnx): enable core dump extraction workflow

Tejaswini-Janjale25 dismissed LittleHuba’s stale review via fd44f42 September 1, 2026 10:30

Tejaswini-Janjale25 force-pushed the teja_itf_test_allow_core_dump branch from af3d4ad to fd44f42 Compare September 1, 2026 10:30

Tejaswini-Janjale25 requested a deployment to workflow-approval September 1, 2026 10:30 — with GitHub Actions Waiting

Navigation Menu

Uh oh!

Enable core dump extraction for bigdata integration test - #739

Enable core dump extraction for bigdata integration test#739
Tejaswini-Janjale25 wants to merge 2 commits into
eclipse-score:mainfrom
Tejaswini-Janjale25:teja_itf_test_allow_core_dump

Tejaswini-Janjale25 commented Jul 22, 2026

Uh oh!

soldier-sky Jul 22, 2026

Uh oh!

Tejaswini-Janjale25 Jul 23, 2026

Uh oh!

soldier-sky Jul 22, 2026

Uh oh!

Tejaswini-Janjale25 Jul 23, 2026

Uh oh!

soldier-sky Jul 24, 2026 •

edited

Loading

Uh oh!

Uh oh!

LittleHuba Jul 30, 2026

Uh oh!

Tejaswini-Janjale25 Aug 10, 2026

Uh oh!

LittleHuba Aug 25, 2026

Uh oh!

Tejaswini-Janjale25 Aug 25, 2026

Uh oh!

LittleHuba Aug 25, 2026

Uh oh!

Tejaswini-Janjale25 Aug 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		# SPDX-License-Identifier: Apache-2.0
		# *******************************************************************************

Uh oh!

Conversation

Tejaswini-Janjale25 commented Jul 22, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

soldier-sky Jul 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

soldier-sky Jul 24, 2026 •

edited

Loading