Adding wait for file ready condition

[MaciejKaszynski]

Adding wait for file functionality.

[github-actions]

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.7.0) and connecting to it...
INFO: Invocation ID: a13ef0dc-076b-4bcc-a7d4-b5a46bb7a0ed
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (45 packages loaded, 10 targets configured)

Analyzing: target //:license-check (130 packages loaded, 142 targets configured)

Analyzing: target //:license-check (148 packages loaded, 3144 targets configured)

Analyzing: target //:license-check (160 packages loaded, 6259 targets configured)

Analyzing: target //:license-check (165 packages loaded, 6308 targets configured)

Analyzing: target //:license-check (167 packages loaded, 6737 targets configured)

Analyzing: target //:license-check (168 packages loaded, 9533 targets configured)

Analyzing: target //:license-check (172 packages loaded, 11429 targets configured)

INFO: Analyzed target //:license-check (173 packages loaded, 11555 targets configured).
[11 / 16] Creating runfiles tree bazel-out/k8-opt-exec-ST-d57f47055a04/bin/external/score_tooling+/dash/tool/formatters/dash_format_converter.runfiles [for tool]; 0s local
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 24.847s, Critical Path: 0.43s
INFO: 16 processes: 4 disk cache hit, 12 internal.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

[NicolasFussberger]

Should this file be called control_client_test_driver like for the other integration tests?

[MaciejKaszynski]

I've rename however we should decide on a central one, in the script

lifecycle/scripts/fix_test_doubles_naming_precommit.py

Line 37 in fe25876

class TestDoubleName(Enum):

it's fake it seems.

[NicolasFussberger]

does it make sense to split this into two methods:

waitForFileExistence
waitForFileRemoval

?

The list of arguments is getting quite long.
I wonder if it would make sense to configure the poll_interval in the constructor?

[MaciejKaszynski]

I don't think so, the implementation is 90% the same, and the difference between waiting for existence or deletion is only one if, which I think is easy enough to read so don't think making a separate private method makes sense either

                    if (!wait_for_existence)
                    {
                        return OsalReturnType::kSuccess;
                    }