Remove test end file - #564
Open
danth wants to merge 1 commit into
Open
Conversation
Previously, the Python script would poll for the existence of a test end file, which was created by the control client test driver. The Python script would send `SIGTERM` to launch manager once the file appeared. Now, the control client test driver just sends `SIGTERM` directly to launch manager. This setup has been a source of flakiness in the past, so removing it may help. Also, it allows us to drop a patch on ITF as we are no longer affected by that bug.
danth
requested review from
FScholPer,
MaciejKaszynski,
NicolasFussberger,
anmittag,
antonkri,
pawelrutkaq and
ramceb
as code owners
August 28, 2026 15:27
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
MaciejKaszynski
requested changes
Aug 28, 2026
| target=target, | ||
| binary_path=str(remote_test_dir / "launch_manager"), | ||
| file_path=remote_test_dir.parent / "test_end", | ||
| process = target.execute_async( |
Contributor
There was a problem hiding this comment.
Should these be non async now?
| args=["-c", str(remote_test_dir / "etc/complex_monitoring.bin")], | ||
| cwd=str(remote_test_dir), | ||
| args=["-c", config_path], | ||
| timeout_s=4.0, |
Contributor
There was a problem hiding this comment.
Would it make sense to still keep a wrapper method?
This would break #525 since there is no central way to inject the program. Also might be good to keep a timeout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the Python script would poll for the existence of a test end file, which was created by the control client test driver. The Python script would send
SIGTERMto launch manager once the file appeared.Now, the control client test driver just sends
SIGTERMdirectly to launch manager.This setup has been a source of flakiness in the past, so removing it may help. Also, it allows us to drop a patch on ITF as we are no longer affected by that bug.
Thanks to @MaciejKaszynski for exploring this the other day 😄