feat: add TimeDaemon CIT with pip hub infrastructure - #122
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
db540ed to
d765fee
Compare
There was a problem hiding this comment.
Sorry, I don't understand this: What is the benefit of using the combination of the pytest/testing_utils plus C++ code over using plain gtest/gmock? At the moment it looks to me making things more complicated and harder to understand.
Imho, for all the component internal testing, I would use gtest. That doesn't mean that everything tested with gtest is automatically a unit test (in the strict sense), it can be also some sort of integration tests - i.e. test which integrate multiple classes and test them together.
Then on the level of testing the whole component as a binary - TimeDaemon in this case - I'd use some pytests framework or ITF to stimulate and test the binary from "outside". And next step would be testing of multiple binaries "playing together".
There was a problem hiding this comment.
Thanks, fair point. You're right that ptp_divider and the single-validator scenarios were duplicating gtest coverage with unnecessary indirection — I've removed them in the latest push.
The CIT layer now only keeps scenarios that wire together two or more production objects: verification.pipeline (PTP stub → verification machine), ipc.shm_roundtrip (publisher/receiver over shared memory), and daemon.lifecycle (full SvtHandler init/shutdown). Single-class behaviour stays with gtest under src/. Added a short README documenting the boundary.
The pytest + test_scenarios stack is the same SCORE-standard framework used for the upcoming module-integration and system-test layers (multi-binary, QEMU), so keeping it here gives one runner surface scaling up to those levels. Let me know if that still feels off.
f74e6e9 to
321294a
Compare
This PR adds TimeDaemon component integration tests with pip hub infrastructure (part 1 of 3):
Part of #56
test QNX