feat: add QNX process configuration, schema, docs for TimeSlave reference Integration - #158
feat: add QNX process configuration, schema, docs for TimeSlave reference Integration#158gordon9901 wants to merge 20 commits into
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
8a7b319 to
d30c777
Compare
43e1a02 to
17581fd
Compare
17581fd to
08d0eeb
Compare
08d0eeb to
1559010
Compare
585f170 to
4a3a6c5
Compare
BjoernAtBosch
left a comment
There was a problem hiding this comment.
Have some finding regarding docs structuring and some clarification points with the testing.
| .. toctree:: | ||
| :maxdepth: 1 | ||
|
|
||
| qnx_setup |
There was a problem hiding this comment.
Please link qnx_setup from the user manual, e.g. from section "Runtime Requirements" or add a new section
There was a problem hiding this comment.
Moved qnx_setup into the user manual under a new "Platform-Specific Setup" section.
| manuals/user_manual | ||
| detailed_design/index | ||
| requirements/index | ||
| manuals/index |
There was a problem hiding this comment.
No need for an index.rst if qnx_setup is linked from user_manual.rst
| manuals/index |
There was a problem hiding this comment.
Removed manuals/index.rst and its toctree entry now that qnx_setup is linked directly from the user manual.
|
|
||
| Configuration | ||
| ************* | ||
|
|
There was a problem hiding this comment.
Could we move section "Configuration" out to the configuration_guide.rst, please?
There was a problem hiding this comment.
Moved the Configuration section (file lookup, QNX fields, PHC config, example) to configuration_guide.rst. qnx_setup.rst now links to it via :ref:.
|
|
||
| // Resolve config path: --config CLI > TIMESLAVE_CONFIG env > ./etc/time_slave_config.json | ||
| fs::path config_path; | ||
| const std::string cli_config = context.get_argument("--config"); |
There was a problem hiding this comment.
Could you shortly describe this parameter in the section "Command-line Arguments" in the configuration_guide.rst, please. There is already some which needs replacement
There was a problem hiding this comment.
Documented --config in the "Command-Line Arguments" section of configuration_guide.rst, replacing the placeholder.
| [uid=0 gid=0 perms=0400] /var/ssh/ssh_host_rsa_key = { | ||
| -----BEGIN OPENSSH PRIVATE KEY----- | ||
| b3BlbnNzaC1rZXktdjEAAAAABG5vbmUAAAAEbm9uZQAAAAAAAAABAAABlwAAAAdzc2gtcn | ||
| NhAAAAAwEAAQAAAYEArR4LKpPGS2mqmnj+d4Y/0DLdYUVQ7hBaR/aYnNbZFUvO3nOFixa4 | ||
| u8pjRQbNFsERvY8o3Q1+SEg/xq+WC4vxhS9bjfMOxO29ncicvcDZR9kVOc/dNCLv6amdOy | ||
| 9V/wN8rb7vy5KhPKF/uubj/HmcwRYZAYV3spR7C4OpN1tSZFBu/rcOYYYC7VxKcshEj8Yt | ||
| 8QX7Bil+MIJHPLu7HTktgxDSp4Y3NUORoV9In1qM+rTJsxDHr3gfCOaN4OnQElwS7RfXx2 | ||
| BFcvA3d4JreynHocpLWUO6rrs1qjCsQZFPqQwBC7SDn8eiKy0XH+yPpioUaJ6L+YFqrk3c | ||
| KxijWKP5/aDuCQrw230mLtWatspHpNUXQSN1FQby6kqLUSV8gXX7lS91AMjdb3sqJ9ebxJ | ||
| xGARbp8ow1yRtTfqk6H04q2QgVQZ/Idso3TzQokt0K/feEdj7SwH3LsaAeMWPyo0WLUOk1 | ||
| 8j46LUEayluF4UcIm8dnjoTywW9A/MS1C+2p4eTbAAAFeAU74GcFO+BnAAAAB3NzaC1yc2 | ||
| EAAAGBAK0eCyqTxktpqpp4/neGP9Ay3WFFUO4QWkf2mJzW2RVLzt5zhYsWuLvKY0UGzRbB | ||
| Eb2PKN0NfkhIP8avlguL8YUvW43zDsTtvZ3InL3A2UfZFTnP3TQi7+mpnTsvVf8DfK2+78 | ||
| uSoTyhf7rm4/x5nMEWGQGFd7KUewuDqTdbUmRQbv63DmGGAu1cSnLIRI/GLfEF+wYpfjCC | ||
| Rzy7ux05LYMQ0qeGNzVDkaFfSJ9ajPq0ybMQx694HwjmjeDp0BJcEu0X18dgRXLwN3eCa3 | ||
| spx6HKS1lDuq67NaowrEGRT6kMAQu0g5/HoistFx/sj6YqFGiei/mBaq5N3CsYo1ij+f2g | ||
| 7gkK8Nt9Ji7VmrbKR6TVF0EjdRUG8upKi1ElfIF1+5UvdQDI3W97KifXm8ScRgEW6fKMNc | ||
| kbU36pOh9OKtkIFUGfyHbKN080KJLdCv33hHY+0sB9y7GgHjFj8qNFi1DpNfI+Oi1BGspb | ||
| heFHCJvHZ46E8sFvQPzEtQvtqeHk2wAAAAMBAAEAAAGAQMkziJWQ6fv7Wp/ZK0XUb8f5TU | ||
| Oxi8YW40OHzXoh93RNULaOzYSNUcnl6Jko+1D5oKUIt+Eq10Yih+qCDoQquJsGelLxvgTy | ||
| py/CaMjZB6hX5zDBKZfBjQJq0xFd73eQmz0PZHHVYWlW8c0imQOyBBiO9yDJsM0cVyzIkO | ||
| zeIqhvQWekPB74zXdybQ5BikSyQLbqQF4a2XCH1FS1K7SQMbKEAymZU5eb0nZkKS6r/87U | ||
| hOzMrgAYLS6K/hbCRXyrAlz61x2hMKTngb/ERWWilqJSGlF8Q4p2LmIxyUnll/C2cq2dvU | ||
| gMARPvZ3DL/QFl4fhLa20vTg83CQNaw6zuEAhTP8lmvDP+4DhtqUPno1T7161OpEHD/ZRb | ||
| oiwXmkwg+0yiR8a9OFiolAhwiqPhqC1W39+coEutjpbXQ1uJVoC0kWHMY9biBa7cb9Cxrq | ||
| boYLOs31sLhTWTrHgIgpsf/FSWYLF5hknZKpVhWQsfowyCtjn6uvVh+bcfUwOMCDthAAAA | ||
| wQDSHJTmW6o6uK53KE6t4c7x+G/qO2Y6FSRQuAbojL1o7gG0SYDFRR3k5fMQ/zqQ1pWrqR | ||
| 5Im+InsfO5KG9489z/SCIXwPq6zev8WJjZV2P3A8qTBPzEeYmicZtJGH/sBuk8Oj/CdOKV | ||
| +GBzkqJdxruiNzLEIGS1gjserT6YJxmA5Q/j1Hiz+bSf66cHhGzmQ092tQ+gGvWPtbFn+D | ||
| YQVbp1GW8E6lbAOBew7IDcWp7LVDZuShBrDvFWtsaupZ7wYxoAAADBAOXzYeYNyrKsFCju | ||
| Qh1Bj0uVOf8lVvygGOzFA/OdqWuRr/h2aPsNYJFbdIiP61mvVd1umJ8BQDiXNlm/YpXOXu | ||
| jOm9a8BVKpMTtoohEkUbqBtv9vx+XHnhLCFYYL4GHJ9Dhj50L3djf++/HkahtZJlTkpSbt | ||
| /ukoZKI1m8MgpyC3xk2UDu1yWNizT2l1L7RnE+ZO4b5U9cONANiYBD8jcnZAvh4ld3ojo0 | ||
| iNXEVEGAKIodMUsgASxGwmoxuX3ugJIwAAAMEAwLp7eVBjg27eflRNYuW8akfDyq9zB1rp | ||
| YGo3GbPytb14WVJuyNL1tJ/B/rdFBg0IXf1FQJEL99kKJP5yDxjOx9kyXBhIWjm8arz39h | ||
| uw0wrsuRl2rrCfMABGS51GohtYmKETZ6x7/2n3l6iz/5mhRN8hW0JluJhKtj6ogO6GZERr | ||
| PTYwQs+9Q7QI1cPx7G5cEPhWhEd+OmKZuXRjhMQQ+ADj/lnUAhhGQatM9/bohJOdObWCRl | ||
| Fu+/MLbJQuA1zpAAAAAAEC | ||
| -----END OPENSSH PRIVATE KEY----- | ||
| } |
There was a problem hiding this comment.
Isn't this key something very specific for a certain testing env?
If yes, could we pass such things in as runtime test config?
(If easy to be achieved - else we can do this in a later improvement step)
There was a problem hiding this comment.
Removed the baked-in key; init.build now generates a fresh RSA host key on the RAM disk via ssh-keygen before starting sshd.
There was a problem hiding this comment.
Sorry for being confused. Shouldn't this be also moved to tools/lint/?
There was a problem hiding this comment.
Kept it under third_party/. It's the BUILD overlay for the http_archive-downloaded third-party C++ library, which by Bazel convention lives alongside vendored deps. The .bzl in tools/lint/ is our custom lint rule that uses the library — different layers, intentionally separated.
This PR adds the configuration required to build and run the TimeSlave process on QNX:
Closes #141
#test QNX