Repository navigation
Conversation
EddyCMWF
approved these changes
Jul 31, 2026
EddyCMWF
left a comment
Collaborator
There was a problem hiding this comment.
Approved from a technical implementation and general structure point of view.
JamesVarndell
requested review from
JamesVarndell,
chpolste,
oiffrig,
pawel-wolff and
sandorkertesz
September 1, 2026 08:13
iainrussell
reviewed
Nov 9, 2026
|
|
||
| Functions should: | ||
|
|
||
| * have explicit inputs and outputs i.e. avoid `**kwargs` |
Member
There was a problem hiding this comment.
Perhaps we should soften this - we do use kwargs quite a lot
Contributor
Author
There was a problem hiding this comment.
Suggested change
| * have explicit inputs and outputs i.e. avoid `**kwargs` | |
| * have well-documented inputs and outputs e.g. avoid bare `**kwargs` where possible |
iainrussell
requested changes
Nov 9, 2026
iainrussell
left a comment
Member
There was a problem hiding this comment.
Hi @Oisin-M,
I really like these docs. I pushed some small fixes, hope you are ok with them. Plus one comment on the kwargs which I think needs to be re-phrased.
corentincarton
approved these changes
Nov 18, 2026
Contributor
Author
Thanks for the fixes! I added a suggestion for the kwargs line - let me know if it aligns with what you had in mind |
sandorkertesz
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Time has come to add some centralised developer instructions to the main earthkit packages that each of the subpackages can link to. Idea is to have as much as possible in the central instructions and as little as possible subpackage-specific instructions so it's more seamless to contribute across the stack and additionally also hopefully even more seamless experience when using the different components.
In this PR, added:
Contributor Declaration
By opening this pull request, I affirm the following: