chore(helm): bump the chart to eUPF 0.7.1 - #646
Merged
Merged
Conversation
The chart's appVersion was still 0.5.0, and image.tag defaults to it, so a helm install with the chart's defaults ran ghcr.io/edgecomllc/eupf:0.5.0 while the current release is v0.7.1. appVersion and the chart version are both 0.7.1 now, as the two have been kept equal at every release. Fixes edgecomllc#644 Signed-off-by: Martin Matyas <martin.matyas@tieto.com> Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
pirog-spb
approved these changes
Sep 27, 2026
Contributor
Author
|
Thanks for the review, @pirog-spb. The red golangci-lint 1.64.8 is built with Go 1.24 and the job runs on Go 1.26.8, so it fails the same way for any pull request until the lint version is raised. |
Collaborator
|
@martin-mat Yes, seems like no reason to postpone approval and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #644.
.deploy/helm/eupf/Chart.yamlstill hadappVersion: 0.5.0, andimage.tagdefaults to the appVersion, sohelm installwith the chart's defaults ranghcr.io/edgecomllc/eupf:0.5.0while the current release is v0.7.1. The project's own deployments did not show it because they override the tag.This sets
appVersionand the chartversionto 0.7.1. The two have been kept equal at every release so far (0.3.2, 0.3.3, 0.4.0, 0.5.0), and the0.7.1image tag exists on ghcr, published by the release build's semver tag.helm lintpasses and the rendered Deployment pullsghcr.io/edgecomllc/eupf:0.7.1.Keeping the two in step automatically at release time, as #644 suggests, is a separate change to the release workflow and is left to the maintainers' preference.
🤖 Generated with Claude Code