Repository navigation
fix: download and extract repository source archives - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repository builds failed before compilation because GitHub rejects the binary release-asset Accept header on its source-archive API, and normal Git archive metadata was rejected during extraction.
Repository lookup errors now name the repository and ref, making shared include failures identifiable. Correct the example refs for dxlevel-restrict, anti-voice-overflow and multicolors to the owner-confirmed
masterbranch.Evidence
application/octet-stream. After correcting that header, extraction failed on itspax_global_headercommit metadata. Focused regressions reproduced both failures.After: The same public Lilac revision downloaded and compiled with official SourceMod 1.13.0.7478 into a package containing the disabled plugin and 19 translations.
go test -race ./...,go vet ./...,CGO_ENABLED=0 go build ./cmd/..., formatting and whitespace checks pass.Merge Danger
Door: two-way
The fix can be reverted without a data migration. Servers need an updated runtime image to use it; private plugin builds still require validation on the target server.
Blast Radius: acquisition
Changes affect source archive requests and tar metadata handling. File/link restrictions, archive bounds, credential handling and package approval remain enforced.