feat: support project file origins and preserve legacy cookie access - #237
Open
raviships wants to merge 2 commits into
Open
feat: support project file origins and preserve legacy cookie access#237raviships wants to merge 2 commits into
raviships wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
raviships
marked this pull request as ready for review
September 7, 2026 07:56
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pairs with https://github.com/edgestorejs/edge-store-app/pull/360. The hosted provider discovers file-delivery origins from the access-token response, and React initializes every required cookie host. After an existing project migrates, returned URLs use its project hostname while saved legacy protected URLs keep working. Upload/delete/get/list calls stay unchanged.
Adds optional provider
baseUrlandclientInit.urls, preserving the existing service/provider fallback and explicitEDGE_STORE_BASE_URLoverride. Includes a minor changeset for sdk/shared/server/react, and SDK schema generation pinned to service commit33ee43df8e8f5918637eb561bd90ccc341f6040b. The regenerated schema also includes existing develop API changes that were not in its previous snapshot. Custom domains are deferred.Validation:
pnpm build,pnpm test,pnpm typecheck,pnpm test:types, and lint for the four affected packages pass. Tests cover both initialization hosts, failure of one required host, legacy fallback, and explicit origin override. Local browser checks against the real service/edge handlers and isolated MySQL passed legacy/project public and protected reads, signed reads without cookies, new-project legacy blocking, and upload/read/delete using returned project URLs. S3 contents and upload-event processing were simulated.Release server and React together before migrating protected projects. Service rollout remains disabled pending the real domain, DNS/TLS, and AWS/browser/accounting checks documented in the paired PR.
Consumer compatibility
Continue storing and using returned URLs rather than constructing hostnames. Migrated projects return project URLs while existing shared-host links remain supported. Protected initialization succeeds only when every required host initializes; older services and other providers retain the
baseUrlpluspathfallback.Upgrade
@edgestore/serverand@edgestore/reacttogether before migration. Review Next.js remotePatterns or other image allowlists, CSP, hardcoded origins, and explicitEDGE_STORE_BASE_URLoverrides. Browser cross-site cookie restrictions still apply; signed read URLs remain available where cookie access is unsuitable. No new customer configuration option is introduced.