Skip to content

fix: fixed router config - #46

Merged
edinstance merged 1 commit into
devfrom
router-config-fixes
Nov 4, 2025
Merged

edinstance merged 1 commit into
devfrom
router-config-fixes

Conversation

@edinstance

@edinstance edinstance commented Nov 4, 2025 •

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Chores
    • Improved environment variable handling for telemetry exporters. Configuration now properly applies default values when environment variables are not explicitly set, ensuring more reliable telemetry endpoint configuration with better scoping and fallback mechanisms.

@edinstance
edinstance merged commit e1123d6 into dev Nov 4, 2025
1 check passed
@coderabbitai

coderabbitai Bot commented Nov 4, 2025 •

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

Walkthrough

Configuration update in router.yml refactors environment variable expansion syntax for OTLP telemetry endpoints, changing from direct variable form to env-qualified form with explicit default fallback mechanism for both tracing and metrics endpoints.

Changes

Cohort / File(s) Summary
OTLP Endpoint Configuration
router.yml
Updated environment variable expansion syntax for tracing.otlp.endpoint and metrics.otlp.endpoint from ${VAR:default} to ${env.VAR:-default} under telemetry.exporters to properly scope variables and handle defaults

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single configuration file affected with straightforward syntax updates
  • No logic changes or conditional branching introduced
  • Changes follow consistent pattern across both endpoint declarations

Poem

🐰 From dollar signs and colons old,
We hop to env-qualified gold,
With dashes marking fallback ways,
Our config shines in modern days! ✨

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch router-config-fixes

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6902bab and 9e22743.

📒 Files selected for processing (1)
  • router.yml (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@edinstance
edinstance deleted the router-config-fixes branch November 4, 2025 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant