Repository navigation
fix: allow unattended-upgrade to handle conffile prompts - #391
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Include stderr in the conffile detection condition so retries stop as intended.
Review effort: Lite
Findings: 1
What changed in this PR
Updates Ubuntu unattended upgrades to handle modified conffiles without interactive prompts.
Changes:
- Adds dpkg options to preserve locally modified conffiles.
- Adjusts retry handling for conffile prompts.
| File | Summary |
|---|---|
playbooks/roles/security/templates/etc/apt/apt.conf.d/50unattended-upgrades |
Configures dpkg conffile handling. |
playbooks/roles/security/tasks/security-ubuntu.yml |
Updates retry behavior; the conffile diagnostic is on stderr, so the fail-fast check needs adjustment. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
nkhaleelulla-sonata-byte
approved these changes
Oct 7, 2026
Contributor
Author
|
atlantis apply |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Finishes DOS-7379
Jira: LP-1289
Changes
50unattended-upgrades: addDpkg::Options { "--force-confdef"; "--force-confold"; };so unmodified conffiles take the package default and modified ones are kept.security-ubuntu.yml: stop retrying onconffile promptso the task fails fast instead of hanging.Impact
Affects all plays that use the
securityrole. Locally modified conffiles are kept, not replaced, on upgrade.Make sure that the following steps are done before merging: