fix: surface backend error message on failed video upload - #115
Merged
santhosh-apphelix-2u merged 1 commit intoSep 10, 2026
Merged
Conversation
abhalsod-sonata
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
errormessage when present, falling back to the previous generic message only if the backend didn't return one.Root cause context (LP-1036)
Partner-reported "Failed to add video" errors were traced to filenames containing non-ASCII characters (e.g. an en dash
–instead of a hyphen-), whichvideos_postrejects with a specific error message that the frontend was discarding. This restriction is intentional — the filename is sent to S3 as object metadata, which must be ASCII — so the backend validation itself is not being changed here, only how its result is communicated to the user.Changes
src/files-and-videos/videos-page/data/thunks.js: pass the backend'serrorresponse field through to thefailAddVideoaction.src/files-and-videos/videos-page/data/slice.js: use that message when building the displayed error, falling back to the generic text if none was provided.