fix: screen reader compatibility - #31
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves accessibility for the games XBlock by adding screen-reader announcements, keyboard navigation/focus management, and hiding decorative UI from assistive technologies for the flashcards and matching games.
Changes:
- Added aria-live regions and JS-based announcements for key gameplay events (page changes, matches, flips, completion).
- Improved keyboard operability and focus management (tabbable matching boxes, Enter/Space activation, focus routing at start/end).
- Added
sr-onlyutility styles, focus-visible outlines, andaria-hiddenfor decorative elements; bumped package version.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Bumps package version to 1.0.14. |
| games/static/js/src/matching.js | Adds live region announcements and keyboard/focus behavior for the matching game. |
| games/static/js/src/flashcards.js | Adds live region announcements, aria updates, and focus behavior for flashcards. |
| games/static/html/matching.html | Adds aria-live region, keyboardable roles/tabindex for boxes, aria-hidden for decorative SVG/spinner, and focusable end-screen region. |
| games/static/html/flashcards.html | Adds aria-live region and adjusts ARIA attributes for the flashcard component/container. |
| games/static/css/matching.css | Adds sr-only utility and focus-visible styling for matching boxes. |
| games/static/css/flashcards.css | Adds sr-only utility and focus-visible styling for the flashcard element. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
djoseph-apphelix
force-pushed
the
djoseph-apphelix/TNL2-343
branch
from
March 23, 2026 06:51
10dbf50 to
3d3056d
Compare
viv-helix
reviewed
Mar 27, 2026
Contributor
|
@djoseph-apphelix add newer version in PR description and create |
viv-helix
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
end screen)