Skip to content

fix: address general accessibility issues and improve usability - #32

Merged
pganesh-apphelix merged 2 commits into
mainfrom
fix/TNL2-552
Apr 6, 2026
Merged

pganesh-apphelix merged 2 commits into
mainfrom
fix/TNL2-552

Conversation

@pganesh-apphelix

@pganesh-apphelix pganesh-apphelix commented Apr 6, 2026 •

Copy link
Copy Markdown
Contributor

Description

  • Fixed the bookmark button label showing as “[Object object]”
  • Corrected header hierarchy by ensuring a single H1 and removing invalid/empty headings

JIRA: https://2u-internal.atlassian.net/browse/TNL2-552

Copilot AI review requested due to automatic review settings April 6, 2026 09:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the XBlock game templates to improve semantic structure and accessibility, and bumps the package version for release.

Changes:

  • Bump package version from 1.0.14 to 1.0.15.
  • Update matching.html and flashcards.html to use semantic <header> and adjust instructional headings.
  • Introduce a wrapper intended to represent “main content” for both games.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 10 comments.

File Description
setup.py Version bump to 1.0.15 for publishing the accessibility/usability updates.
games/static/html/matching.html Semantic header + heading level change + new wrapper around the game grid content.
games/static/html/flashcards.html Semantic header + heading level change + new wrapper around the flashcard area content.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread games/static/html/matching.html Outdated
Comment thread games/static/html/matching.html
Comment thread games/static/html/flashcards.html
Comment thread games/static/html/flashcards.html
Comment thread games/static/html/matching.html Outdated
Comment thread games/static/html/flashcards.html
Comment thread games/static/html/matching.html
Comment thread games/static/html/flashcards.html
Comment thread games/static/html/matching.html Outdated
Comment thread games/static/html/flashcards.html
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 6, 2026 10:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread games/static/html/matching.html
Comment thread games/static/html/matching.html
Comment thread setup.py
@pganesh-apphelix
pganesh-apphelix merged commit fedf1a3 into main Apr 6, 2026
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants