Skip to content

[VSCodeSweeper MVP — test only] [html] don't validate custom event handlers as JavaScript #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
egamma wants to merge 2 commits into
base: main
Choose a base branch
from
+116 −4
Draft

[VSCodeSweeper MVP — test only] [html] don't validate custom event handlers as JavaScript #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11e49c1
fix #79631: [html] don't validate custom event handlers as JavaScript
egamma Jun 29, 2026
cfdf41a
address codex review (round 1) — #79631
egamma Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
116 changes: 112 additions & 4 deletions extensions/html-language-features/server/src/modes/embeddedSupport.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,115 @@ export const CSS_STYLE_RULE = '__';

interface EmbeddedRegion { languageId: string | undefined; start: number; end: number; attributeValue?: boolean }

const eventHandlerAttributes = new Set([
'onabort',
'onafterprint',
'onanimationcancel',
'onanimationend',
'onanimationiteration',
'onanimationstart',
'onauxclick',
'onbeforeinput',
'onbeforematch',
'onbeforetoggle',
'onbeforeunload',
'onblur',
'oncancel',
'oncanplay',
'oncanplaythrough',
'onchange',
'onclick',
'onclose',
'oncontextlost',
'oncontextmenu',
'oncontextrestored',
'oncopy',
'oncuechange',
'oncut',
'ondblclick',
'ondrag',
'ondragend',
'ondragenter',
'ondragleave',
'ondragover',
'ondragstart',
'ondrop',
'ondurationchange',
'onemptied',
'onended',
'onerror',
'onfocus',
'onformdata',
'ongotpointercapture',
'onhashchange',
'oninput',
'oninvalid',
'onkeydown',
'onkeypress',
'onkeyup',
'onlanguagechange',
'onload',
'onloadeddata',
'onloadedmetadata',
'onloadstart',
'onlostpointercapture',
'onmessage',
'onmousedown',
'onmouseenter',
'onmouseleave',
'onmousemove',
'onmouseout',
'onmouseover',
'onmouseup',
'onoffline',
'ononline',
'onpagehide',
'onpageshow',
'onpaste',
'onpause',
'onplay',
'onplaying',
'onpointercancel',
'onpointerdown',
'onpointerenter',
'onpointerleave',
'onpointermove',
'onpointerout',
'onpointerover',
'onpointerrawupdate',
'onpointerup',
'onpopstate',
'onprogress',
'onratechange',
'onreset',
'onresize',
'onscroll',
'onscrollend',
'onsecuritypolicyviolation',
'onseeked',
'onseeking',
'onselect',
'onslotchange',
'onstalled',
'onstorage',
'onsubmit',
'onsuspend',
'ontimeupdate',
'ontoggle',
'ontouchcancel',
'ontouchend',
'ontouchmove',
'ontouchstart',
'ontransitioncancel',
'ontransitionend',
'ontransitionrun',
'ontransitionstart',
'onunload',
'onvolumechange',
'onwaiting',
'onwheel'
]);


export function getDocumentRegions(languageService: LanguageService, document: TextDocument): HTMLDocumentRegions {
const regions: EmbeddedRegion[] = [];
Expand Down Expand Up @@ -243,9 +352,8 @@ function append(result: string, str: string, n: number): string {
}

function getAttributeLanguage(attributeName: string): string | null {
const match = attributeName.match(/^(style)$|^(on\w+)$/i);
if (!match) {
return null;
if (attributeName.toLowerCase() === 'style') {
return 'css';
}
return match[1] ? 'css' : 'javascript';
return eventHandlerAttributes.has(attributeName.toLowerCase()) ? 'javascript' : null;
}
4 changes: 4 additions & 0 deletions extensions/html-language-features/server/src/test/embedded.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,9 @@ suite('HTML Embedded Support', () => {

assertLanguageId('<label data-content="|Checkbox"/>', 'html');
assertLanguageId('<label on="|Checkbox"/>', 'html');
assertLanguageId('<div onInvalidAttribute="|test test"></div>', 'html');
assertLanguageId('<div onclick="|test test"></div>', 'javascript');
assertLanguageId('<body onbeforeunload="|return false"></body>', 'javascript');
});

test('Script content', function (): any {
Expand All @@ -125,6 +128,7 @@ suite('HTML Embedded Support', () => {
assertEmbeddedLanguageContent('<script>var data=100; <!--this comment should not give error--> </script>', 'javascript', ' var data=100; /* this comment should not give error */ ');
assertEmbeddedLanguageContent('<div onKeyUp="foo()" onkeydown="bar()"/>', 'javascript', ' foo(); bar(); ');
assertEmbeddedLanguageContent('<div onKeyUp="return"/>', 'javascript', ' return; ');
assertEmbeddedLanguageContent('<body onbeforeunload="return false"></body>', 'javascript', ' return false; ');
assertEmbeddedLanguageContent('<div onKeyUp=return\n/><script>foo();</script>', 'javascript', ' return;\n foo(); ');
});

Expand Down