Repository navigation
Ehsanking fix export dimensions - #10
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Add the product analytics chart canvas flow, fix the Studio sidebar overflow regression at 125% scaling, and make the Playwright font-export test cross-platform. Bump the app version to 1.0.3 so the desktop release workflow publishes updated Windows and macOS installers. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: beb884a29c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| > | ||
| <RenderPlacedLogo config={logoConfig} isDraggable={false} /> | ||
| <CanvasStickersOverlay stickers={canvasStickers.infographic || []} isEditable={false} /> | ||
| <div className="pointer-events-none absolute left-0 top-0 z-20" style={{ width: 350, transform: `scale()`, transformOrigin: 'top left' }}> |
There was a problem hiding this comment.
The infographic editor stores layer coordinates against its fixed 350px-wide canvas, but the export stage is rendered at the selected asset's native width (594px for Zhaket and up to 1200px elsewhere). scale() is invalid CSS and is discarded, so every newly supported infographic layer keeps its 350px offsets and dimensions in the native-width export; for example, a chart centered at x: 175 in the editor is exported well left of center. Supply the intended scale factor (with the existing top-left origin) so exports match the canvas.
Useful? React with 👍 / 👎.
| > | ||
| <RenderPlacedLogo config={logoConfig} isDraggable={false} /> | ||
| <CanvasStickersOverlay stickers={canvasStickers.infographic || []} isEditable={false} /> | ||
| <div className="pointer-events-none absolute left-0 top-0 z-20" style={{ width: 350, transform: `scale()`, transformOrigin: 'top left' }}> |
There was a problem hiding this comment.
The newly added layer wrapper and all of its children are absolutely positioned, so they add no height to exportInfographicRef; exportInfographicDisplay.displayHeight is only passed to the renderer and never applied to the export root. When a user places a layer below the normal infographic rows (including the new test's y: 900 scenario after clearing or shortening rows), html-to-image captures only the root's normal-flow height and crops that layer from PNG/PDF/PSD/ZIP exports. Set the export stage's minimum height from the computed infographic display height before capturing it.
Useful? React with 👍 / 👎.
No description provided.