fix: respect HTTPX client ownership during cleanup - #109
Merged
Merged
Conversation
Keep injected HTTPX clients open while closing calculator-owned clients and the impersonating session. Document the consumer cleanup obligation. Amp-Thread-ID: https://ampcode.com/threads/T-01a0f7ee-1716-708f-95e3-e71ad595da40 Co-authored-by: Kevin Stillhammer <kevin.stillhammer@tado.com>
eifinger
force-pushed
the
fix/ha-client-ownership
branch
from
October 1, 2026 15:02
a5e6ba9 to
e26e159
Compare
Remove the lifecycle details requested in review. Amp-Thread-ID: https://ampcode.com/threads/T-01a0f7ee-1716-708f-95e3-e71ad595da40 Co-authored-by: Kevin Stillhammer <kevin.stillhammer@tado.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leave injected HTTPX clients open when closing a WazeRouteCalculator, while still closing its owned HTTPX client and impersonating session. Preserve impersonating-session cleanup when owned HTTPX cleanup raises.
Document that consumers must await calculator cleanup after validation and on unload. This makes cleanup compatible with Home Assistant’s shared HTTPX client; it does not automatically clean up calculators that consumers never close.
Thread: https://ampcode.com/threads/T-01a0f7ee-1716-708f-95e3-e71ad595da40