Clarify output order - #175
Open
ejmahler wants to merge 3 commits into
Open
Conversation
Contributor
|
Item 3 has the direction flipped, the negative frequencies come out in descending magnitude. Bins 4 and 5 of a 6-point transform are -2 and -1, so the one closest to zero is last. On length, subjective of course, but I think a concrete example earns the two lines. It makes the even-length middle bin obvious in a way more words don't: //! Elements in the output have the following order:
//!
//! 1. Frequency zero
//! 2. Positive frequencies, from smallest magnitude to largest
//! 3. Negative frequencies, from largest magnitude to smallest
//!
//! For example, with 6 elements and a sample rate `fs`, the output frequencies are
//! `[0, fs/6, 2*fs/6, 3*fs/6, -2*fs/6, -fs/6]`, where `3*fs/6` is the Nyquist frequency.
I also numbered the list 1/2/3 instead of three times |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #104