Repository navigation
machine pages 1.7 beside 1.2, with the elekloader that picks the one a build links with - #14
Merged
Merged
Conversation
…e one a build links with machine-pages 1.7 (the machine-pages-v1.7 pre-release, built from the v0.10.0 tag) is listed beside 1.2, both held. It adds a filter tab to the machine menu, MIDI CCs for a page's extra values and, on OS 1.54, the shared SDK's machines. 1.2 stays for OB-1: OB-1 0.5 and 0.6 patch the MIDI CC range lookup that machine-pages has patched itself since 1.3, so they link with 1.2 only. elekloader edc3043 (elekloader/elekloader#359) gives a mod the newest version of what it requires that the build links with: OB-1 takes 1.2, the other machine mods 1.7. The page groups a mod's versions by repository, so 1.2's entries name elekloader/elekloader as 1.7's do. The same elekloader makes the page change the core without a message, and ticks a mod added before the stock file when the file comes. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes that go together:
elekloader.refmoves fromdca7a03toedc3043(A mod builds with the versions it was made for, and the page picks them without a word elekloader#359).Why both at once
machine-pages has patched the MIDI CC range lookup itself since 1.3. OB-1 0.5 and 0.6 patch the same place, so they link with machine pages 1.2 and are refused beside anything newer. That is why the shop stayed on 1.2.
With elekloader#359 a mod gets the newest version of what it requires that the build links with: OB-1 takes 1.2, every other machine mod takes 1.7, and a build with both takes 1.2. Listing 1.7 without that elekloader would grey OB-1 out.
What the new machine pages gives
What else changes
elekloader/elekloaderin place ofirpina/elekloader: the page groups a mod's versions by repository, and the files are the same release's.Checked
tests/test_units.pyon this list: passes, the list keeps its layout.tests/probe_digitakt_src.py --storagein digikit's emulator.After the merge
pagesbuilds and publishes the site. On it, with a Digitakt mk1 stock file: two machine pages cards (1.2 and 1.7), OB-1 says + Add and brings 1.2, DT-FM brings 1.7.🤖 Generated with Claude Code