Repository navigation
fix(input): export ActionRegistry - #37
Merged
Merged
Conversation
`engine.actions` is public and typed ActionRegistry, and games register their actions on it, but the class and its ActionDefinition / ActionRecord / ActionDescriptor types were never exported. Code that wants to type an action sink, or build a registry for a test, had to reach into dist internals. Re-export them from `renderoni/input`, which `renderoni` already re-exports. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Owner
|
Thanks! Optional follow-up: add a type-only reference to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
engine.actionsis public and typedActionRegistry, and games register their actions on it, but the class and itsActionDefinition/ActionRecord/ActionDescriptortypes were not exported. Typing an action sink, or building a registry in a test, meant reaching intodistinternals.This re-exports them from
renderoni/input, whichrenderonialready re-exports. No behaviour change.Verification: typecheck, build, 228/228 tests. A public-exports test covers the new exports.
🤖 Generated with Claude Code