Repository navigation
fix(media): bound untrusted RIFF LIST traversal (RUST-BUG-181) - #319
Merged
Merged
Conversation
Contributor
Author
|
Parent-coordinated supersession: qualification runs for this head have been cancelled to prioritize #321, which removes unused Slint/fontconfig APT setup after repeated mirror-DNS failures before Cargo. Source commits and completed evidence are preserved. The parent will refresh this branch onto the actual merged prerequisite and rerun all applicable gates before integration. These deliberate cancellations do not establish a product regression or a passing qualification. |
itlezy
force-pushed
the
fix/riff-parser-bounds
branch
from
November 11, 2026 16:41
ef30be6 to
7c53bf5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An untrusted RIFF file can nest LIST chunks until metadata extraction exhausts the stack. Limit traversal to 16 LIST levels and the existing 2 MiB metadata prefix, while continuing to extract valid sibling metadata.
Boundary tests cover accepted and rejected nesting depths, sibling preservation, and nested AVI headers with a truncated trailing list. Scoped ED2K validation passed 1,275 tests on the unchanged behavioral patch before this base refresh; current-head normal commit and push checks passed. Full platform and CodeQL qualification is required on this PR.
Closes #283.
Parent coordination: this existing consolidation lane owns only RIFF metadata extraction and its private regression tests. It runs independently of atomic settings #316, profile ownership #317, packaging #318 and release-guidance work; the parent owns merge order and final-main qualification. The parallel-approved label authorizes these coordinated PRs without changing their required gates.