Skip to content

fix(media): bound untrusted RIFF LIST traversal (RUST-BUG-181) - #319

Merged
itlezy merged 2 commits into
mainfrom
fix/riff-parser-bounds
Nov 11, 2026
Merged

itlezy merged 2 commits into
mainfrom
fix/riff-parser-bounds

Conversation

@itlezy

@itlezy itlezy commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

An untrusted RIFF file can nest LIST chunks until metadata extraction exhausts the stack. Limit traversal to 16 LIST levels and the existing 2 MiB metadata prefix, while continuing to extract valid sibling metadata.

Boundary tests cover accepted and rejected nesting depths, sibling preservation, and nested AVI headers with a truncated trailing list. Scoped ED2K validation passed 1,275 tests on the unchanged behavioral patch before this base refresh; current-head normal commit and push checks passed. Full platform and CodeQL qualification is required on this PR.

Closes #283.

Parent coordination: this existing consolidation lane owns only RIFF metadata extraction and its private regression tests. It runs independently of atomic settings #316, profile ownership #317, packaging #318 and release-guidance work; the parent owns merge order and final-main qualification. The parallel-approved label authorizes these coordinated PRs without changing their required gates.

@itlezy itlezy added the parallel-approved Maintainer-approved exception for deliberately parallel human pull requests label Nov 11, 2026
@itlezy

itlezy commented Nov 11, 2026

Copy link
Copy Markdown
Contributor Author

Parent-coordinated supersession: qualification runs for this head have been cancelled to prioritize #321, which removes unused Slint/fontconfig APT setup after repeated mirror-DNS failures before Cargo. Source commits and completed evidence are preserved. The parent will refresh this branch onto the actual merged prerequisite and rerun all applicable gates before integration. These deliberate cancellations do not establish a product regression or a passing qualification.

@itlezy
itlezy force-pushed the fix/riff-parser-bounds branch from ef30be6 to 7c53bf5 Compare November 11, 2026 16:41
@itlezy
itlezy merged commit 8e1cc3e into main Nov 11, 2026
25 checks passed
@itlezy
itlezy deleted the fix/riff-parser-bounds branch November 11, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parallel-approved Maintainer-approved exception for deliberately parallel human pull requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RUST-BUG-181 - Bound RIFF media parsing and retain malformed-input regressions

1 participant