Skip to content

Define standard arm preview views in presets - #133

Merged
kou merged 1 commit into
enactic:mainfrom
stevenaya:feat/preset-default-views
Nov 11, 2026
Merged

kou merged 1 commit into
enactic:mainfrom
stevenaya:feat/preset-default-views

Conversation

@stevenaya

Copy link
Copy Markdown
Contributor

Store the standard V1/V2 preview cameras in their presets so the default display launch can use the shared bimanual.rviz configuration for both single-arm and bimanual models.

Changes

  • Add preview.view.eye/lookat to the 11 existing V1/V2 presets.
  • Preserve the former single-arm camera for single-arm variants, including gripper variants, and the former bimanual camera for the two default bimanual presets.
  • Keep arm_only.rviz available for existing tutorial commands. The default rviz_config remains bimanual.rviz.

This PR is based directly on main and is independent of #131. Cell's own view remains in #131. Joint positions and model configuration are unchanged.

Validation

  • All 33 existing ROS 2 Jazzy tests pass; no tests added.
  • All 11 views convert back to the previous RViz Orbit parameters within 1e-7 (yaw compared modulo 2 pi).
  • Parsed preset contents are unchanged apart from the new preview field. No RViz files, launch code or development documentation changed.

Copilot AI balanced review requested due to automatic review settings November 11, 2026 09:08

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@kou
kou merged commit 81544ac into enactic:main Nov 11, 2026
10 checks passed

This branch was successfully deployed

1 active deployment
release — 34b6c50b Deployed Nov 11, 2026 by stevenaya via Publish #496
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants