Skip to content

Unify V1/V2 model assembly and add V2 camera assets - #97

Draft
stevenaya wants to merge 7 commits into
enactic:mainfrom
stevenaya:feature/v2-camera-mounts
Draft

stevenaya wants to merge 7 commits into
enactic:mainfrom
stevenaya:feature/v2-camera-mounts

Conversation

@stevenaya

@stevenaya stevenaya commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

This draft tracks the completed V1/V2 migration and remaining preview/Cell work. #127 is merged.

PR Scope Status
#132 Preset init_pos/view support and RViz cleanup Ready for review; based on main
#131 Cell model, articulated lifter and Cell preview defaults Draft; follows #132

This integration branch includes #132. Cell remains on its own branch. The #132 suite has 33 existing tests; the unchanged final Cell tree passed 35. No test cases were added.

Cell-only changes.

@stevenaya
stevenaya force-pushed the feature/v2-camera-mounts branch from 76400b5 to ef91899 Compare October 28, 2026 06:51
@stevenaya
stevenaya force-pushed the feature/v2-camera-mounts branch from ef91899 to 37bf37e Compare October 28, 2026 07:35
@stevenaya
stevenaya force-pushed the feature/v2-camera-mounts branch from 37bf37e to 7075d62 Compare October 28, 2026 08:42
@stevenaya
stevenaya force-pushed the feature/v2-camera-mounts branch from 7075d62 to f0333ef Compare October 29, 2026 06:57
@stevenaya
stevenaya force-pushed the feature/v2-camera-mounts branch from f0333ef to 73304b3 Compare October 29, 2026 15:52
@stevenaya
stevenaya force-pushed the feature/v2-camera-mounts branch from 73304b3 to c4bea31 Compare October 30, 2026 14:48
@stevenaya
stevenaya force-pushed the feature/v2-camera-mounts branch from c4bea31 to 6a66874 Compare October 30, 2026 18:11
@stevenaya
stevenaya force-pushed the feature/v2-camera-mounts branch from 6a66874 to 9a6fe67 Compare October 30, 2026 18:20
@stevenaya
stevenaya force-pushed the feature/v2-camera-mounts branch from 9a6fe67 to 7cbb1c9 Compare October 31, 2026 19:07
@stevenaya
stevenaya force-pushed the feature/v2-camera-mounts branch from 7cbb1c9 to 942231b Compare October 31, 2026 21:14
@stevenaya
stevenaya force-pushed the feature/v2-camera-mounts branch from 942231b to d0602fd Compare October 31, 2026 22:25
@stevenaya
stevenaya force-pushed the feature/v2-camera-mounts branch from d0602fd to 84e1e2a Compare October 31, 2026 23:18
@stevenaya
stevenaya force-pushed the feature/v2-camera-mounts branch from 8787a26 to 9ba8203 Compare November 2, 2026 09:37
@stevenaya
stevenaya force-pushed the feature/v2-camera-mounts branch from 9ba8203 to e389f09 Compare November 4, 2026 01:54
@stevenaya
stevenaya force-pushed the feature/v2-camera-mounts branch from e389f09 to a524028 Compare November 4, 2026 07:03
@stevenaya
stevenaya force-pushed the feature/v2-camera-mounts branch from a524028 to fcc4805 Compare November 4, 2026 07:50
@stevenaya
stevenaya force-pushed the feature/v2-camera-mounts branch from fcc4805 to a6661fb Compare November 4, 2026 07:55
@stevenaya
stevenaya force-pushed the feature/v2-camera-mounts branch from a6661fb to 237aac0 Compare November 4, 2026 08:01
@stevenaya
stevenaya force-pushed the feature/v2-camera-mounts branch from 237aac0 to 06314a1 Compare November 4, 2026 09:15
@stevenaya
stevenaya force-pushed the feature/v2-camera-mounts branch from 06314a1 to 5d5430e Compare November 4, 2026 11:22
@stevenaya
stevenaya force-pushed the feature/v2-camera-mounts branch from 5d5430e to 9b1901a Compare November 4, 2026 11:39
@stevenaya
stevenaya force-pushed the feature/v2-camera-mounts branch 2 times, most recently from ff9be36 to 6f6bcae Compare November 6, 2026 00:47
The RobotModel displays in `arm_only.rviz` and `bimanual.rviz` carried a
snapshot of the link tree from whichever model was loaded last (13 and 28
entries).  Every entry was a default value - alpha 1, no axes, no trail, all
links enabled - so they carried no display behaviour, but the names went stale:
`openarm_link8` no longer exists in the V1 single arm, `v10_body_link0` is not
the current body name, and neither file matches the V2 or Cell link sets.

Keep the five group-level keys and let RViz rebuild the tree from
`/robot_description` instead.  Nothing else changes: displays, fixed frame,
camera pose and window geometry are byte-identical, and the files no longer
need touching when a new model revision renames links.

198 lines removed, no additions.

This branch was successfully deployed

1 active deployment
release — 943bb17f Deployed Nov 11, 2026 by stevenaya via Publish #488
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant