Skip to content

Main menu: Restart logo animation when displayed#2581

Open
wjt wants to merge 1 commit into
mainfrom
wjt/main-menu-restart-logo-animation-when-displayed
Open

Main menu: Restart logo animation when displayed#2581
wjt wants to merge 1 commit into
mainfrom
wjt/main-menu-restart-logo-animation-when-displayed

Conversation

@wjt

@wjt wjt commented Jul 22, 2026

Copy link
Copy Markdown
Member

Previously the logo was animated once, then stayed on its last frame.
I think it's nice to reshow the animation when moving back from the
credits or options screens.

Add the necessary API to AnimatedTextureRect to make this work.

Previously the logo was animated once, then stayed on its last frame.
I think it's nice to reshow the animation when moving back from the
credits or options screens.

Add the necessary API to AnimatedTextureRect to make this work.
@wjt
wjt requested a review from a team as a code owner July 22, 2026 09:32
@wjt wjt changed the title Main menu: Restart logo animation when displayed [1/1] Main menu: Restart logo animation when displayed Jul 22, 2026
@wjt wjt changed the title [1/1] Main menu: Restart logo animation when displayed ain menu: Restart logo animation when displayed Jul 22, 2026
@wjt wjt changed the title ain menu: Restart logo animation when displayed Main menu: Restart logo animation when displayed Jul 22, 2026
@wjt

wjt commented Jul 22, 2026

Copy link
Copy Markdown
Member Author

I'm happy to be disagreed with on this one! I have just had versions of this patch lying around in my local clone for months, so decided to finish it to see if others agree that this is good.

@github-actions

Copy link
Copy Markdown

Play this branch at https://play.threadbare.game/branches/endlessm/wjt/main-menu-restart-logo-animation-when-displayed/.

(This launches the game from the start, not directly at the change(s) in this pull request.)

@manuq

manuq commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

I'm happy to be disagreed with on this one! I have just had versions of this patch lying around in my local clone for months, so decided to finish it to see if others agree that this is good.

I find it a bit too much to also play the animation when going back from Options or Credits, to be honest. But is only a matter of taste. Feel free to merge it!

@wjt

wjt commented Jul 22, 2026

Copy link
Copy Markdown
Member Author

Ok, I trust your judgement! In that case I will revise this PR to keep the new features in AnimatedTextureRect but preserve the old behaviour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants